UPSTREAM: 51727: ensure oc get deals with unstructured resources #16082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
juanvallejo
changed the title
juanvallejo
assigned fabianofranz and enj and unassigned smarterclayton and stevekuznetsov
|
/test extended_conformance_gce |
Ensure we are dealing with unstructured objects before attempting to compose into an unstructured list.
juanvallejo
force-pushed
the
jvallejo/ensure-unstructured-objects-before-composing
branch
from
dc80f83 to
6974922
Compare
juanvallejo
changed the title
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, fabianofranz, juanvallejo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
@juanvallejo add a test (can be a separate PR) that does |
|
Automatic merge from submit-queue |
juanvallejo
deleted the
jvallejo/ensure-unstructured-objects-before-composing
branch
openshift-merge-robot
added a commit
that referenced
this pull request
Sep 12, 2017
Automatic merge from submit-queue (batch tested with PRs 15927, 16283, 16239, 16271, 16287) ensure `oc get` handles mixed resource types Adds a test to ensure `oc get` does not panic when given a list of both structured and unstructured resources. Tests changes added in #16082 cc @enj @openshift/cli-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16064
Addresses BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1487245
$ oc get ...assumed all resources returned from a resource builder were unstructured objects.This patch ensures we are dealing with unstructured objects before attempting to
compose into an unstructured list.
cc @openshift/cli-review @enj