-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run the bare kube controllers #16089
run the bare kube controllers #16089
Conversation
I'm looking at memory numbers but I'm probably going to have to require that informers not be duplicated in 3.7 until we get other things under control. I'm ok with a clean patch that we plan on removing that provides them and uses this structure, but the memory numbers aren't good enough to do this yet. |
Why do you believe memory usage will improve going forward? |
Memory usage will improve or the beatings will continue. |
ba3276f
to
42e2346
Compare
Alright, I've create a carry patch to allow us to shim in our informers. It's ugly, but I think its better than carrying a separate config generation. I'll make a followup to remove building the config. /assign mfojtik |
42e2346
to
ca837c2
Compare
This doesn't work because of the multiple informer starts caused by sending our informers to the kube-controller process. This may require greater violence. |
ca837c2
to
521c66f
Compare
Wow, green |
521c66f
to
30df806
Compare
etcd |
/lgtm Potential fix for https://bugzilla.redhat.com/show_bug.cgi?id=1491202 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue (batch tested with PRs 16089, 16305, 16219, 15934, 16366) |
This runs the kube controllers separately based on their command to avoid any customization and set us up to run them as-is, without modification in a future release (double lease thing).
@smarterclayton