switch route extra auth check to SAR client #16147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
openshift-merge-robot
added
the
approved
|
/retest |
|
@enj ptal |
|
/approve no-issue |
|
/lgtm |
enj
reviewed
Sep 5, 2017
| Verb: "create", | ||
| Group: routeapi.GroupName, | ||
| Resource: "routes", | ||
| Subresource: "custom-host", |
There was a problem hiding this comment.
I know this is preexisting, but does it have some special meaning?
There was a problem hiding this comment.
I know this is preexisting, but does it have some special meaning?
yeah, they used a subresource as an authorization check on a different field.
|
/lgtm Just a question about the subresource. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, enj, mfojtik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the route authz check to use a client.
@soltysh @mfojtik this is on the path to splitting the route storage