Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 45352: Pod (Anti)affinity shouldn't be respected across namespaces. #16240

Conversation

ravisantoshgudimetla
Copy link
Contributor

xref: https://bugzilla.redhat.com/show_bug.cgi?id=1483119
Upstream fix+unit test:
kubernetes/kubernetes#45352
kubernetes/kubernetes#45152

Origin 3.6 fix:
#16016

/cc @sjenning @aveshagarwal @deads2k

Only difference between #16016 and this one is, podAntiAffinity and podAffinity are in Annotations rather than in pod Spec.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 8, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ravisantoshgudimetla
We suggest the following additional approver: stevekuznetsov

Assign the PR to them by writing /assign @stevekuznetsov in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ravisantoshgudimetla
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

@ravisantoshgudimetla: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/end_to_end d0f4b63 link /test end_to_end
ci/openshift-jenkins/integration d0f4b63 link /test integration
ci/openshift-jenkins/extended_conformance_install_update d0f4b63 link /test extended_conformance_install_update
ci/openshift-jenkins/extended_conformance_gce d0f4b63 link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Sep 10, 2017

It seems the error is happening at
PID 12531: /tmp/origin_version.sh:2: os::build::version::get_vars exited with status 127.?

Anything I could do to pass this?

@stevekuznetsov
Copy link
Contributor

No, sorry, that is a red herring. The real issue was:

+ hack/env make build-router-e2e-test
make: *** No rule to make target `build-router-e2e-test'.  Stop.

@stevekuznetsov
Copy link
Contributor

Question @ravisantoshgudimetla @sjenning why is this going into Origin, not OSE?

@sjenning
Copy link
Contributor

@stevekuznetsov sorry, there have been so many PRs with this change, I didn't notice this was against Origin.

@ravisantoshgudimetla can reopen against OSE 3.5?

@sjenning sjenning closed this Sep 12, 2017
@ravisantoshgudimetla
Copy link
Contributor Author

Sure @sjenning. I will raise against ose 3.5 but before that, I want to push these changes to ose 3.6 and it is failing at etcd installation.

@ravisantoshgudimetla ravisantoshgudimetla deleted the release-1.5 branch October 4, 2017 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants