-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 45352: Pod (Anti)affinity shouldn't be respected across namespaces. #16240
UPSTREAM: 45352: Pod (Anti)affinity shouldn't be respected across namespaces. #16240
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ravisantoshgudimetla Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/retest |
@ravisantoshgudimetla: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
It seems the error is happening at Anything I could do to pass this? |
No, sorry, that is a red herring. The real issue was:
|
Question @ravisantoshgudimetla @sjenning why is this going into Origin, not OSE? |
@stevekuznetsov sorry, there have been so many PRs with this change, I didn't notice this was against Origin. @ravisantoshgudimetla can reopen against OSE 3.5? |
Sure @sjenning. I will raise against ose 3.5 but before that, I want to push these changes to ose 3.6 and it is failing at etcd installation. |
xref: https://bugzilla.redhat.com/show_bug.cgi?id=1483119
Upstream fix+unit test:
kubernetes/kubernetes#45352
kubernetes/kubernetes#45152
Origin 3.6 fix:
#16016
/cc @sjenning @aveshagarwal @deads2k
Only difference between #16016 and this one is, podAntiAffinity and podAffinity are in Annotations rather than in pod Spec.