ensure node exists if --node-name given #16387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
juanvallejo
force-pushed
the
jvallejo/ensure-node-exists
branch
from
6efc94e to
447a8a5
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabianofranz, juanvallejo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Automatic merge from submit-queue (batch tested with PRs 16439, 16218, 16387, 16509) |
juanvallejo
added a commit
to juanvallejo/origin
that referenced
this pull request
Oct 24, 2017
PR openshift#16387 prevented a debug pod from being created at all, if a specified node-name pointed to a node that did not exist. Although the patch aimed to make "debug" command failures more immediate, a client should not attempt to retrieve a specific node in the "debug" command, as there is no guarantee that the user has access to retrieve node information. While this means that the "debug" command
openshift-merge-robot
added a commit
that referenced
this pull request
Oct 24, 2017
Automatic merge from submit-queue. prevent client from looking up specific node in `oc debug` Reverts #16387 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1505698 PR #16387 prevented a debug pod from being created at all, if a specified node-name pointed to a node that did not exist. Although the patch aimed to make "debug" command failures more immediate, a client should not attempt to retrieve a specific node in the "debug" command, as there is no guarantee that the user has access to retrieve node information. While this means that the "debug" command cc @openshift/cli-review @smarterclayton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1474262
Ensures a node exists before creating a debug pod (if a nodeName is specified using
--node-name).If a nodeName is not specified, current behavior is unchanged.
Before
After
cc @openshift/cli-review