Bug 1481147 - Fix default pod image for network diagnostics #16439
Conversation
openshift-ci-robot
added
the
size/M
pravisankar
added
component/diagnostics
and removed
size/M
|
@openshift/networking @knobunc PTAL |
|
[test] |
- This also ensures network diagnostics pod and test pod images uses deployed openshift version/tag (not the latest) so that it doesn't need to download another same image with latest tag.
Currently when network diags fails, it only informs how many test pods failed but doesn't provide why those pods failed. This change will fetch logs for the pods in case of setup failure.
pravisankar
force-pushed
the
netdiags-image-check
branch
from
fa00ddd to
74a6699
Compare
openshift-ci-robot
added
the
size/M
|
@sosiouxme Should this be assigned to you? |
|
looks like a flake As an assignee, what am I supposed to do? Review only? Give a /lgtm? Doesn't look like I need to /approve. |
|
@sosiouxme merge-bot says this pr needs an approver from pkg/diagnostics/OWNERS and pkg/oc/OWNERS |
openshift-merge-robot
added
the
approved
pravisankar
removed
the
approved
openshift-merge-robot
added
the
approved
| @@ -131,6 +123,14 @@ func GetTestPod(testPodImage, testPodProtocol, podName, nodeName string, testPod | |||
| return pod | |||
| } | |||
|
|
|||
| func getTrimmedImage(image string) string { | |||
| // Image format could be: [<dns-name>/]openshift/origin-deployer[:<tag>] | |||
| tokens := strings.Split(image, "/") | |||
There was a problem hiding this comment.
Can't you use https://golang.org/pkg/strings/#SplitN
There was a problem hiding this comment.
We don't know how many /s will be present in the given image (dns path may have many) and we only care about the last token.
|
/approve |
|
/lgtm |
|
@pravisankar you're also an approver for that path so my approval is superfluous :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, knobunc, pravisankar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue |
This also ensures network diagnostics pod and test pod images uses
deployed openshift version/tag (not the latest) so that it doesn't
need to download another same image with latest tag.
Print more details when network diagnostics test setup fails.
Currently when network diags fails, it only informs how many test pods failed but doesn't provide why those pods failed. This change will fetch logs for the pods in case of setup failure.