-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catalog: RBAC - added missing get for service-catalog-controller #16440
catalog: RBAC - added missing get for service-catalog-controller #16440
Conversation
/lgtm |
This is part of #16220 |
/test cmd |
gonna need to generate bindata. |
…kers, instances and credentials
cb06c56
to
ca9d312
Compare
Thanks @bparees, added |
@jboyd01 can we also add the feature flag for originating identity while we're at this? |
@bparees we need to cut a new release to get all of the feature flag. I'm working on that now - it will drop tomorrow into origin. |
/lgtm |
@bparees can you approve this one? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, jboyd01, pmorie The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
@jboyd01: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue (batch tested with PRs 16420, 16440) |
service-catalog-controller role was missing the get operation for ServiceBrokers, ServiceInstances and ServiceInstanceCredentials