-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Router: Do not include accept-proxy in port list when using proxy protocol and syn eater #16444
Router: Do not include accept-proxy in port list when using proxy protocol and syn eater #16444
Conversation
Hi @cldmnky. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cldmnky, rajatchopra The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@rajatchopra not sure if I should do anything more here? Should I run a retest? |
/ok-to-test |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
Automatic merge from submit-queue (batch tested with PRs 16454, 16444, 16522) |
When enabling both proxy protocol (ROUTER_USE_PROXY_PROTOCOL) and DROP_SYN_DURING_RESTART, the ports variable in reload-haproxy is set to:
This makes the reload script fail with:
This PR fixes that by adding
-o
to grep, which makes grep only return the match from the reqex