add --sub-path opt to set-volume cmd

[juanvallejo]

Fixes #16275

Adds a --sub-path option to oc set volume ....
Updates command to match web-console functionality.

cc @openshift/cli-review

[fabianofranz]

Worth adding some tests to test/cmd/volumes.sh.

[fabianofranz]

Not necessarily part of this PR, but while reviewing I noticed this cmd doesn't protect against mutually exclusive flags like --list --mount-path=/foo (and now --list --sub-path). Of course having a set command that does --remove and --list is a good part of the cause. It's hard to fix a bad cmd usability design now, but we should open an issue to at least try to make the set of flags behave correctly against each other. ;)

[juanvallejo]

@fabianofranz

Not necessarily part of this PR, but while reviewing I noticed this cmd doesn't protect against mutually exclusive flags like --list --mount-path=/foo (and now --list --sub-path). Of course having a set command that does --remove and --list is a good part of the cause. It's hard to fix a bad cmd usability design now, but we should open an issue to at least try to make the set of flags behave correctly against each other. ;)

Sounds good to me, will open issue to track this

[juanvallejo]

@fabianofranz

Worth adding some tests to test/cmd/volumes.sh.

Thanks, done!

[fabianofranz]

/kind bug
/lgtm
/approve

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianofranz, juanvallejo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• contrib/completions/OWNERS [fabianofranz,juanvallejo]
• pkg/oc/OWNERS [fabianofranz]
• test/cmd/OWNERS [fabianofranz]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[juanvallejo]

/retest

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 16545, 16684, 16643, 16459, 16682).