Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: switch to generated clients (part 1) #16478

Merged
merged 2 commits into from
Sep 22, 2017
Merged

cli: switch to generated clients (part 1) #16478

merged 2 commits into from
Sep 22, 2017

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Sep 21, 2017

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 21, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2017
@mfojtik mfojtik force-pushed the generated-clients-cli-3 branch from 6a0d884 to ca51469 Compare September 21, 2017 15:21
@deads2k
Copy link
Contributor

deads2k commented Sep 21, 2017

/lgtm

failures are legit

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2017
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik mfojtik force-pushed the generated-clients-cli-3 branch from ca51469 to 91469e4 Compare September 22, 2017 11:39
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2017
@mfojtik
Copy link
Contributor Author

mfojtik commented Sep 22, 2017

@deads2k investigating the deployment log one, seems weird, like we missed registration of DeploymentLogOptions somewhere.

@mfojtik
Copy link
Contributor Author

mfojtik commented Sep 22, 2017

@deads2k @sttts seems like we missing something in registration: https://gist.github.com/mfojtik/c43e9d1a0967cb63c225e063fd80ff5a

@mfojtik
Copy link
Contributor Author

mfojtik commented Sep 22, 2017

failures should be fixed

@mfojtik
Copy link
Contributor Author

mfojtik commented Sep 22, 2017

flake: #16167

/retest

@deads2k
Copy link
Contributor

deads2k commented Sep 22, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mfojtik
Copy link
Contributor Author

mfojtik commented Sep 22, 2017

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16452, 16478, 16457)

@openshift-merge-robot openshift-merge-robot merged commit 5350bad into openshift:master Sep 22, 2017
@mfojtik mfojtik deleted the generated-clients-cli-3 branch September 5, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabianofranz fabianofranz

@juanvallejo juanvallejo

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mfojtik @deads2k @openshift-bot @openshift-merge-robot @fabianofranz @juanvallejo @openshift-ci-robot