Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provisioner template for local storage #16538

Merged
merged 2 commits into from
Nov 23, 2017
Merged

Add provisioner template for local storage #16538

merged 2 commits into from
Nov 23, 2017

Conversation

jsafrane
Copy link
Contributor

Local volumes are alpha feature of 3.7 and need some example how to set it up.

Based on https://github.com/kubernetes-incubator/external-storage/tree/master/local-volume, tailored for OpenShift.

I renamed original local-storage-examples to hostpath-examples.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 25, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Sep 26, 2017

Please use YAML for all templates/examples.

@jsafrane
Copy link
Contributor Author

@mfojtik, it is yaml. Only existing files (moved across directories) are json.

@jsafrane jsafrane mentioned this pull request Sep 27, 2017
Merged
@0xmichalis
Copy link
Contributor

/retest

@jsafrane
Copy link
Contributor Author

@rootfs, please review

/assign @soltysh
PTAL and approve

rootfs
rootfs reviewed Oct 20, 2017
View reviewed changes
examples/storage-examples/local-examples/README.md Outdated

## Overview
Local volumes are PersistentVolumes representing local mounted filesystems.
In future they may be extended to raw block devices.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, PTAL

@rootfs
Copy link
Member

rootfs commented Oct 20, 2017

minor nit, looks good to me

@jsafrane
Copy link
Contributor Author

/retest
#16654

@rootfs
Copy link
Member

rootfs commented Oct 23, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2017
@rootfs
Copy link
Member

rootfs commented Oct 23, 2017

/assign @soltysh

@rootfs rootfs closed this Oct 23, 2017
@rootfs rootfs reopened this Oct 23, 2017
@soltysh
Copy link
Contributor

soltysh commented Nov 21, 2017

/approve
/retest

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, rootfs, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 21, 2017
@jsafrane
Copy link
Contributor Author

/retest
#17263

@jsafrane
Copy link
Contributor Author

/retest
#17263 again

@jsafrane jsafrane mentioned this pull request Nov 22, 2017
Closed
@jsafrane
Copy link
Contributor Author

/retest
did I break anything?

@stevekuznetsov
Copy link
Contributor

@jsafrane to see what the next steps are for your PR, view the Submit Queue status:

Submit Queue — PR does not have approved label.

@jsafrane jsafrane added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2017
@jsafrane
Copy link
Contributor Author

/retest
#15630

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@jsafrane
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 23, 2017 •
edited
Loading

@jsafrane: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update 276079c link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16538, 17430, 17432, 17433, 17442).

@openshift-merge-robot openshift-merge-robot merged commit 95b9bfa into openshift:master Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootfs rootfs rootfs left review comments

Assignees

@soltysh soltysh

@screeley44 screeley44

@rootfs rootfs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jsafrane @mfojtik @0xmichalis @rootfs @soltysh @openshift-merge-robot @stevekuznetsov @openshift-ci-robot @screeley44