Sleep at the end of every hack/env invocation for logs
#16604
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/XS
|
@smarterclayton this obviously doesn't work as it gives the args to whatever command you asked -- do we want to run a shell as the entrypoint and have it do this? |
When a container exits, the Docker daemon is not very faithful in collecting all of the logs that the contained processes created before they finished. We need to sleep at the end of every `hack/env` call to ensure that we have enough time to notice what happened and we do not lose logs. Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/env-sleep
branch
from
075c8c7 to
2ff4749
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
/retest |
|
@smarterclayton why does |
|
/retest |
|
Because of changes to hack |
| # container exit races with log collection so we | ||
| # need to sleep at the end but preserve the exit | ||
| # code of whatever the user asked for us to run | ||
| cmd=( '/bin/bash' '-c' "${cmd[*]}; return_code=\$?; sleep 1; exit \${return_code}" ) |
There was a problem hiding this comment.
You're not wrong
|
@stevekuznetsov anything holding this up? |
|
@smarterclayton are you nack or ack here |
|
Don't have time to care, this looks like it has a better fix, if we have an
open issue and owner to come back and fix later I'm fine with the short hack
On Oct 4, 2017, at 1:05 PM, Ben Parees <[email protected]> wrote:
@stevekuznetsov <https://github.com/stevekuznetsov> anything holding this
up?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16604 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p1T25DBYAp37WN3q3ZxPuoYp3CcTks5so7regaJpZM4PnoJb>
.
|
stevekuznetsov
changed the title
hack/env invocation for logshack/env invocation for logs
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 16615, 16604). |
When a container exits, the Docker daemon is not very faithful in
collecting all of the logs that the contained processes created before
they finished. We need to sleep at the end of every
hack/envcall toensure that we have enough time to notice what happened and we do not
lose logs.
Signed-off-by: Steve Kuznetsov [email protected]