Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 53318: create separate transports for liveness and readiness probes #16633

Merged
merged 1 commit into from
Oct 3, 2017
Merged

UPSTREAM: 53318: create separate transports for liveness and readiness probes #16633

merged 1 commit into from
Oct 3, 2017

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Oct 2, 2017

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 2, 2017
@sjenning
Copy link
Contributor Author

sjenning commented Oct 2, 2017

/test integration

@sjenning
Copy link
Contributor Author

sjenning commented Oct 3, 2017

@smarterclayton @derekwaynecarr this is all green now and merged upstream. Can I get review/lgtm?

@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning, smarterclayton

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2017
@sjenning sjenning added the kind/bug Categorizes issue or PR as related to a bug. label Oct 3, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit afd90cd into openshift:master Oct 3, 2017
@deads2k
Copy link
Contributor

deads2k commented Oct 4, 2017

@smarterclayton @derekwaynecarr this is all green now and merged upstream. Can I get review/lgtm?

We specifically requested upstreams be held while we rebased. The rebase was green and this is forcing a re-pick or re-bump.

@sjenning
Copy link
Contributor Author

sjenning commented Oct 4, 2017

@deads2k didn't know this was a thing. Where/when did the UPSTREAM hold get communicated? Also, #16664 is the queue. Sorry.

@soltysh
Copy link
Contributor

soltysh commented Oct 4, 2017

@sjenning email from Oct 2nd titled 'Holding upstream commit until rebase lands'.

@deads2k
Copy link
Contributor

deads2k commented Oct 4, 2017

@deads2k didn't know this was a thing. Where/when did the UPSTREAM hold get communicated? Also, #16664 is the queue. Sorry.

tagged that one do-not-merge

@rphillips rphillips mentioned this pull request Jul 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sjenning @smarterclayton @openshift-merge-robot @deads2k @soltysh @openshift-ci-robot