-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add statefulsets to PodForResource #16652
Conversation
Lacks a test. |
@Kargakis do we have any tests for PodForResource? |
This needs a test in end-to-end since it's fixing cli functionality. Pretty sure we are testing |
@Kargakis test added |
flake: #16654 /retest |
Awesome, thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kargakis, mfojtik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 16347, 16652). |
Thanks |
/cherrypick stage |
@Kargakis: PR 16652 failed to apply on top of branch "stage": exit status 128 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-3.6 |
@Kargakis: New pull request created: #17151 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes: #16650
@smarterclayton PTAL