Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 53446: kubelet: add latency metrics to network plugin manager #16696

Merged
merged 1 commit into from
Oct 6, 2017
Merged

UPSTREAM: 53446: kubelet: add latency metrics to network plugin manager #16696

merged 1 commit into from
Oct 6, 2017

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Oct 5, 2017

kubernetes/kubernetes#53446

Right now, we can't account for all the time spent in the PLEG loop. We have kubelet_docker_operations_latency_microseconds to account for container runtime delays but nothing to capture delays due to the CNI plugin. This PR adds those metrics.

xref https://bugzilla.redhat.com/show_bug.cgi?id=1486914

@smarterclayton @eparis @smarterclayton @jeremyeder @DirectXMan12 @dcbw

Adding do-not-merge until rebase completes.

@sjenning sjenning added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2017
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2017
@sjenning sjenning added the kind/bug Categorizes issue or PR as related to a bug. label Oct 5, 2017
@derekwaynecarr
Copy link
Member

holding pending #16615

pick looks good though.

@derekwaynecarr
Copy link
Member

/approve

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2017
@eparis
Copy link
Member

eparis commented Oct 5, 2017

/hold cancel
looks like the rebase merged.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2017
@eparis
Copy link
Member

eparis commented Oct 5, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2017
@eparis eparis changed the title UPSTREAM: 53446 kubelet: add latency metrics to network plugin manager UPSTREAM: 53446: kubelet: add latency metrics to network plugin manager Oct 5, 2017
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2017
@sjenning
Copy link
Contributor Author

sjenning commented Oct 5, 2017

ugh. left out a colon in the UPSTREAM commit msg. can i get re-lgtm?

@sjenning
Copy link
Contributor Author

sjenning commented Oct 5, 2017

/retest

@eparis
Copy link
Member

eparis commented Oct 5, 2017

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, eparis, sjenning

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2017 •
edited
Loading

@sjenning: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/origin/unit d834c0b link /test origin-ut
ci/openshift-jenkins/origin/verify d834c0b link /test origin-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16700, 16696, 16698, 16661, 16704).

@openshift-merge-robot openshift-merge-robot merged commit 32a0fbe into openshift:master Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derekwaynecarr derekwaynecarr

@eparis eparis

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sjenning @derekwaynecarr @eparis @openshift-merge-robot @openshift-ci-robot @dcbw