Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 53135: Fixed counting of unbound PVCs towards limit of attached volumes. #16718

Merged

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Oct 6, 2017

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 6, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Oct 6, 2017

@Kargakis what does "error starting Jenkins job" mean?

@0xmichalis
Copy link
Contributor

It means that there was an error when we tried to start the job in Jenkins. This one should be fixed for now.

/retest

@0xmichalis
Copy link
Contributor

@csrwng I had to rekick the unit test job because it wasn't accepting parameters...

@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 6, 2017

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 6, 2017

/test openshift-jenkins/origin/unit

@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 6, 2017

/test all

@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 6, 2017

@Kargakis unit & verify test were either not restarted or they still fail very quickly

@rootfs
Copy link
Member

rootfs commented Oct 6, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2017
@0xmichalis
Copy link
Contributor

Both jobs are non-blocking now so you can safely ignore them.

@eparis
Copy link
Member

eparis commented Oct 6, 2017

/lgtm

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, jsafrane, rootfs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2017
@eparis
Copy link
Member

eparis commented Oct 6, 2017

/retest

@0xmichalis
Copy link
Contributor

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 6, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 88b46e1 into openshift:master Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants