Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary anonymous function #16867

Merged
merged 1 commit into from
Oct 16, 2017
Merged

remove unnecessary anonymous function #16867

merged 1 commit into from
Oct 16, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Oct 13, 2017

There is an upstream replacement for this function. This cleans up the last usages.

blocks #16861
/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 13, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2017
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 13, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Oct 13, 2017

/retest

@0xmichalis 0xmichalis removed their assignment Oct 14, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Oct 16, 2017

/retest

mfojtik
mfojtik reviewed Oct 16, 2017
View reviewed changes
test/integration/cli_get_token_test.go Outdated
"github.com/openshift/origin/pkg/cmd/util/tokencmd"
userclient "github.com/openshift/origin/pkg/user/generated/internalclientset/typed/user/internalversion"
testutil "github.com/openshift/origin/test/util"
testserver "github.com/openshift/origin/test/util/server"
"k8s.io/client-go/rest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this up

mfojtik
mfojtik reviewed Oct 16, 2017
View reviewed changes
test/integration/router/router_http_server.go Outdated
@@ -19,6 +19,8 @@ import (
kapi "k8s.io/kubernetes/pkg/api"

"github.com/openshift/origin/pkg/cmd/util"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nuke this new-line

@mfojtik
Copy link
Contributor

mfojtik commented Oct 16, 2017

minor nits, LGTM

@deads2k
Copy link
Contributor Author

deads2k commented Oct 16, 2017

comments addressed. tagging

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2017
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16867, 16231).

@openshift-merge-robot openshift-merge-robot merged commit bb412d8 into openshift:master Oct 16, 2017
@openshift-ci-robot
Copy link

@deads2k: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update 002dcf7 link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k deleted the client-11-anon branch January 24, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik mfojtik left review comments

Assignees

@mfojtik mfojtik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deads2k @openshift-merge-robot @mfojtik @openshift-ci-robot @0xmichalis