Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 50583: Make endpoints controller update based on semantic equality #16889

Merged
merged 1 commit into from
Oct 17, 2017
Merged

UPSTREAM: 50583: Make endpoints controller update based on semantic equality #16889

merged 1 commit into from
Oct 17, 2017

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Oct 16, 2017

Fixes #16583

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 16, 2017
@openshift-merge-robot openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. vendor-update Touching vendor dir or related files labels Oct 16, 2017
@liggitt liggitt mentioned this pull request Oct 16, 2017
Merged
@joelsmith
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@joelsmith
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot added a commit that referenced this pull request Oct 17, 2017
@openshift-merge-robot
Merge pull request #16890 from liggitt/endpoints-empty-subsets-3.6
5fa553e 
Automatic merge from submit-queue.

UPSTREAM: 50583: Make endpoints controller update based on semantic equality

Pick of #16889 for 3.6
Fixes #16583
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 6350b90 into openshift:master Oct 17, 2017
@liggitt liggitt deleted the endpoints-empty-subsets-3.7 branch October 26, 2017 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joelsmith joelsmith

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @joelsmith @openshift-merge-robot @openshift-bot @deads2k @openshift-ci-robot