Service catalog rebase v0.1.0 #17027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2017 14:23
…service-catalog/' changes from aa27078754..510060232e 510060232e origin build: add origin tooling de45e94 v0.1.0 chart changes (openshift#1468) 0bb9982 Modify Makefile to only specify ldflags once (openshift#1471) 5d6afac Fixes openshift#735: Add repo-sync script for charts (openshift#1453) 630f13f fix lingering unversioned client API (openshift#1466) 6f49128 Fix several logging errors (openshift#1464) 2aece61 Delete removed serviceClasses when they have no instances left (openshift#1450) 179d302 Uncommenting UID field after updating to k8s 1.8 (openshift#1457) b70c076 Reorder class and plan creation; test plan conflict handling (openshift#1459) 4bea012 Use versioned client APIs (openshift#1458) ff4af30 clean up logic for 410 gone deprovision poll (openshift#1452) 3fddf27 clean up logic and fix message for failed poll (openshift#1451) 40926cd Fix typo from openshift#1354 (openshift#1456) ff86ef2 Delete removed serviceplans when they have no instances left (openshift#1444) 8411a16 tweak binding setAndUpdateOrphanMitigation function (openshift#1448) ce28252 Combine apiserver and controller-manager into a single service-catalog image (openshift#1343) 7bbc8ee Check service class / plan before allowing provisioning or plan changes. (openshift#1439) baf28de Create listers before adding event handlers in controller (openshift#1446) 294157d remove setServiceBindingCondition dependency on controller (openshift#1441) 118a0f7 Fix typo in validation (openshift#1447) 117bfbd clean up error logging (openshift#1443) dff470f Move "External" around in some resource names/properties (openshift#1354) 0885edb Adding expectedGot function and using it. (openshift#1440) a7d582e Pretty controller broker (openshift#1442) c5edfaf Set apimachinery build variables with semver info (openshift#1429) 0e90d82 Add a pretty formatter for ClusterService[Class|Plan] (openshift#1408) fb874df Remove deprecated basic auth config support (openshift#1431) f4cd181 Migrate to metav1 methods for manipulating controllerRefs (openshift#1433) 96b286e Make service/plan reference fields on instance spec selectable (openshift#1422) 33f2b04 First example using the pretty context builder. (openshift#1403) 7852917 Stop using corev1.ObjectReference and corev1.LocalObjectReference (openshift#1417) fcf9480 Add tests for plan updates (openshift#1412) 819332e Add root CAs (openshift#1419) b49a76a Clean Makefile a little (openshift#1399) d681da0 Use a separate etcd prefix for each integration test to keep tests isolated (openshift#1415) 314a622 Wire etcd prefix to storage and call complete with options (openshift#1394) REVERT: aa27078754 origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 510060232e54eb64b294213bb5d7847e169a2fac
openshift-ci-robot
added
the
size/XXL
openshift-merge-robot
added
needs-api-review
vendor-update
|
/test cmd |
apiserver and controller-manager are now all built into the new service-catalog binary. Each component is invoked via argument similar to how hyperkube functions.
jpeeler
force-pushed
the
sc-rebase-0.1.0
branch
from
c5a348b to
de7f4c1
Compare
|
/test service-catalog |
|
@jpeeler I think you need to look at hack/test-cmd.sh locally - it's been flaking reliably and isn't something that has typically flaked out on us during these rebase PRs. |
|
still debugging locally, but just in case it is a flake... |
|
/lgtm |
| @@ -73,15 +74,13 @@ $(error Unsupported platform to compile for) | |||
| endif | |||
|
|
|||
| GO_BUILD = env GOOS=$(PLATFORM) GOARCH=$(ARCH) go build -i $(GOFLAGS) \ | |||
| -ldflags "-X $(SC_PKG)/pkg.VERSION=$(VERSION)" | |||
| -ldflags "-X $(SC_PKG)/pkg.VERSION=$(VERSION) $(BUILD_LDFLAGS)" | |||
There was a problem hiding this comment.
Do you need to support Go 1.4? That version requires -X A B not -X A=B
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpeeler, pmorie, stevekuznetsov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
/hold my LGTM should not be the final call here |
openshift-ci-robot
added
the
do-not-merge/hold
|
Wait no didn't see Paul's LGTM /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
Automatic merge from submit-queue (batch tested with PRs 17032, 17027). |
|
Automatic merge from submit-queue (batch tested with PRs 17032, 17027). |
|
@jpeeler congrats you get not one but TWO merges!!@!@!@ |
openshift-merge-robot
added a commit
to openshift/origin-web-console
that referenced
this pull request
Oct 25, 2017
Automatic merge from submit-queue. Adopt renamed service external name properies origin-web-common 0.0.69 -> 0.0.70 origin-web-catalog 0.0.59 -> 0.0.60 https://github.com/openshift/origin-web-common/releases/tag/v0.0.70 https://github.com/openshift/origin-web-catalog/releases/tag/v0.0.60 Requires openshift/origin#17027 Requires openshift/origin-web-common#235 Requires openshift/origin-web-catalog#524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beta service catalog release. Some of the building and image usage has slightly changed due to the use of a single binary, rather than two from before.