-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upstream azure fixes #17052
upstream azure fixes #17052
Conversation
… client Signed-off-by: Huamin Chen <[email protected]>
Signed-off-by: Huamin Chen <[email protected]>
…e nil Signed-off-by: Huamin Chen <[email protected]>
@rootfs Do you have a bugzilla to link to in the description? |
Signed-off-by: Huamin Chen <[email protected]>
bfd9a3a
to
54542e0
Compare
@deads2k not yet. This is an accumulated patch around multiple issues. |
@deads2k BZ created. |
/test extended_conformance_install_update |
/kind bug |
/retest |
/lgtm |
/test extended_conformance_install |
@eparis can you merge? thanks |
/assign @deads2k |
I'll but because we're currently branching (jobs running as we speak), I need to /hold until this afternoon and you'll have to open a pull to release-3.8 too once we have it. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: childsb, deads2k, rootfs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/hold cancel |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@rootfs: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Automatic merge from submit-queue. |
fix https://bugzilla.redhat.com/show_bug.cgi?id=1506708 and https://bugzilla.redhat.com/show_bug.cgi?id=1513859