-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] Webconsole 01 command #17251
[POC] Webconsole 01 command #17251
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@deads2k PR needs rebase |
@deads2k When I run this, I see the full URL get set in the index.html <base href="https://172.30.61.120:443/console/"> It should just be https://github.com/openshift/origin/blob/master/pkg/assets/handlers.go#L128 Any ideas? |
47d68be
to
7f0d02a
Compare
@spadgett fixed |
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
proxy is now at #17862 |
@spadgett @jwforres A pull that just wires up an origin-web-console command that can consume an AssetConfig (you've got some a params you'll want to add). You can create an image that runs the command then I've included here some install manifests you can use like
oc process -f install/origin-web-console/apiserver-template.yaml -p "API_SERVER_CONFIG=$(cat install/origin-web-console/apiserver-config.yaml)" | oc apply -f -
.I've also included a very simple proxy (it would need hardening before we actually merge it) that for now unconditionally proxies /console to
webconsole.openshift-web-console.svc
.The pod I've got running is definitely proxying through, but it's hitting an error "Client state could not be verified" which I would have expected from the oauth server, but a grep is claiming is in bindata somewhere. Let me know if there's a request I need to chase down somewhere.