Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Webconsole 01 command #17251

Closed
wants to merge 3 commits into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Nov 9, 2017

@spadgett @jwforres A pull that just wires up an origin-web-console command that can consume an AssetConfig (you've got some a params you'll want to add). You can create an image that runs the command then I've included here some install manifests you can use like oc process -f install/origin-web-console/apiserver-template.yaml -p "API_SERVER_CONFIG=$(cat install/origin-web-console/apiserver-config.yaml)" | oc apply -f -.

I've also included a very simple proxy (it would need hardening before we actually merge it) that for now unconditionally proxies /console to webconsole.openshift-web-console.svc.

The pod I've got running is definitely proxying through, but it's hitting an error "Client state could not be verified" which I would have expected from the oauth server, but a grep is claiming is in bindata somewhere. Let me know if there's a request I need to chase down somewhere.

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-api-review labels Nov 9, 2017
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 9, 2017
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2017
@openshift-merge-robot
Copy link
Contributor

@deads2k PR needs rebase

@spadgett
Copy link
Member

@deads2k When I run this, I see the full URL get set in the index.html base element

<base href="https://172.30.61.120:443/console/">

It should just be href="/console/"

https://github.com/openshift/origin/blob/master/pkg/assets/handlers.go#L128
https://github.com/openshift/origin/blob/master/pkg/assets/apiserver/asset_apiserver.go#L269

Any ideas?

@deads2k deads2k force-pushed the webconsole-01-command branch from 47d68be to 7f0d02a Compare November 13, 2017 19:20
@deads2k
Copy link
Contributor Author

deads2k commented Nov 13, 2017

@spadgett fixed

@openshift-ci-robot
Copy link

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/verify 7f0d02a link /test verify
ci/openshift-jenkins/cmd 7f0d02a link /test cmd
ci/openshift-jenkins/unit 7f0d02a link /test unit
ci/openshift-jenkins/end_to_end 7f0d02a link /test end_to_end
ci/openshift-jenkins/extended_networking_minimal 7f0d02a link /test extended_networking_minimal
ci/openshift-jenkins/extended_conformance_install_update 7f0d02a link /test extended_conformance_install_update
ci/openshift-jenkins/extended_conformance_gce 7f0d02a link /test extended_conformance_gce
ci/openshift-jenkins/integration 7f0d02a link /test integration
ci/openshift-jenkins/cross 7f0d02a link /test cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor Author

deads2k commented Dec 18, 2017

proxy is now at #17862

@deads2k deads2k closed this Dec 18, 2017
@deads2k deads2k deleted the webconsole-01-command branch January 24, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-api-review needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants