switch the easy admission plugins to external types #17288
Conversation
openshift-ci-robot
added
the
size/L
openshift-merge-robot
added
the
approved
|
/unassign |
deads2k
force-pushed
the
admission-01-external-easy
branch
from
dc56064 to
cb71efe
Compare
deads2k
force-pushed
the
admission-01-external-easy
branch
from
cb71efe to
faf4959
Compare
|
@stevekuznetsov https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/17288/test_pull_request_origin_extended_builds/629/ looks like a set up failure. Maybe something related to branching? |
|
/retest |
|
@deads2k that should be fixed now /retest |
|
Alright, I've convinced myself that it isn't going to be easier to break our internal api dependency on internal kube apis. Looks like this is the path forward. |
|
/test all |
| return admission.NewForbidden(attr, fmt.Errorf("build strategy %s is not allowed", strategyTypeString(strategy))) | ||
| } | ||
|
|
||
| func strategyTypeString(strategy buildapi.BuildStrategy) string { |
There was a problem hiding this comment.
seems like build api helper to me
There was a problem hiding this comment.
seems like build api helper to me
Single point of use is here.
|
/lgtm @bparees fyi |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
| panic(err) | ||
| } | ||
| return out | ||
| } |
There was a problem hiding this comment.
Single point of use is here.
There was a problem hiding this comment.
you realize i'm probably about to have to do this everywhere else as part of converting to v1 apis, right?
| panic(err) | ||
| } | ||
| return out | ||
| } |
There was a problem hiding this comment.
Single point of use is here.
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I also picked up the user change before I realized how far it rippled.