Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove kubectl from openshift (but not oc) #17305

Merged
merged 3 commits into from
Nov 20, 2017
Merged

remove kubectl from openshift (but not oc) #17305

merged 3 commits into from
Nov 20, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Nov 14, 2017

alternative to #17264

This makes kubectl behave like kubectl even when it's a renamed oc.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 14, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Nov 14, 2017

/retest

@deads2k deads2k force-pushed the bin-03-kubectl-again branch from 8c52833 to e15e62f Compare November 14, 2017 18:51
@deads2k
Copy link
Contributor Author

deads2k commented Nov 14, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Nov 14, 2017

@stevekuznetsov I'm trying to stop renaming openshift to kubectl, but I'm trying to keep the code that allows oc when called kubectl running kubectl. I can't figure out how all those bits are wired in the hack scripts. Can I get a little help?

@deads2k
Copy link
Contributor Author

deads2k commented Nov 16, 2017

/retest

2 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Nov 17, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Nov 17, 2017

/retest

@stevekuznetsov
Copy link
Contributor

@deads2k I totally didn't see your comment about the scripts until now - sorry! Let's sync tomorrow if you still need help.

@deads2k deads2k force-pushed the bin-03-kubectl-again branch from f68603e to 8faa87c Compare November 20, 2017 15:20
@juanvallejo
Copy link
Contributor

@deads2k this lgtm

@deads2k deads2k force-pushed the bin-03-kubectl-again branch from 8faa87c to 08de059 Compare November 20, 2017 16:24
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 4a76a82 into openshift:master Nov 20, 2017
@openshift-ci-robot
Copy link

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update 08de059 link /test extended_conformance_install_update
ci/openshift-jenkins/extended_conformance_gce 08de059 link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k deleted the bin-03-kubectl-again branch January 24, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanvallejo juanvallejo juanvallejo approved these changes

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deads2k @openshift-merge-robot @stevekuznetsov @juanvallejo @openshift-ci-robot @liggitt @smarterclayton