Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make assetconfig a top level type #17310

Merged

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Nov 14, 2017

@liggitt @smarterclayton API change need to split the webconsole out. This never went into openshift/api, so I'd like to see it merged.

@spadgett fyi

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 14, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-api-review labels Nov 14, 2017
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Nov 14, 2017

/retest

@smarterclayton
Copy link
Contributor

lgtm

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Nov 14, 2017

@liggitt minimal conflict potential. Eliminates the only carry in https://github.com/openshift/origin-web-console-server . After that we can rebase origin-web-console-server at our leisure.

@deads2k
Copy link
Contributor Author

deads2k commented Nov 14, 2017

@liggitt minimal conflict potential. Eliminates the only carry in https://github.com/openshift/origin-web-console-server . After that we can rebase origin-web-console-server at our leisure.

And come to think of it, until we do something with the assetconfig types, I don't think we'll care for quite a while.

@php-coder
Copy link
Contributor

/unassign

@simo5
Copy link
Contributor

simo5 commented Nov 14, 2017

/unassign

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17184, 17082, 17304, 17310).

@openshift-merge-robot openshift-merge-robot merged commit d42a000 into openshift:master Nov 15, 2017
@deads2k deads2k deleted the webconsole-05-type-enablement branch January 24, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-api-review size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants