-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make assetconfig a top level type #17310
make assetconfig a top level type #17310
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/retest |
lgtm |
@liggitt minimal conflict potential. Eliminates the only carry in https://github.com/openshift/origin-web-console-server . After that we can rebase origin-web-console-server at our leisure. |
And come to think of it, until we do something with the assetconfig types, I don't think we'll care for quite a while. |
/unassign |
/unassign |
Automatic merge from submit-queue (batch tested with PRs 17184, 17082, 17304, 17310). |
@liggitt @smarterclayton API change need to split the webconsole out. This never went into openshift/api, so I'd like to see it merged.
@spadgett fyi