-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.7] UPSTREAM: 55631: Parse and return the last line in the log even if it is partial #17320
Conversation
@Kargakis we should allow merge to 3.7 branches ;-) @stevekuznetsov i think this will have to go via green button. /test |
/unassign |
Branch weirdness will be fixed once we move away from /lgtm |
/test crio |
I want to hold on this until the upstream PR is actually merged. |
Misunderstood comment from @mfojtik |
/lgtm cancel |
/test crio |
1 similar comment
/test crio |
@derekwaynecarr @stevekuznetsov we need this for 3.7 as well, could any of you merge this? (Upstream has merged) |
just found out the repo to backport, closing. |
2ff33db
to
e16fc4a
Compare
… is partial Signed-off-by: Antonio Murdaca <[email protected]>
e16fc4a
to
618fa2f
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: runcom Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
As requested elsewhere by @smarterclayton - this is back porting #17198 to |
@runcom: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Being back ported #17546 |
Same as #17198 but for
release-3.7
.@derekwaynecarr @mrunalp PTAL
Signed-off-by: Antonio Murdaca [email protected]