Begin moving pkgs w/ deps on pkg/oc #17332
Conversation
openshift-ci-robot
added
the
size/M
juanvallejo
force-pushed
the
jvallejo/move-some-files-to-pkg-oc
branch
from
61bae71 to
b544cce
Compare
| @@ -25,7 +25,6 @@ import ( | |||
| "github.com/openshift/origin/pkg/cmd/server/bootstrappolicy" | |||
| imageapi "github.com/openshift/origin/pkg/image/apis/image" | |||
| imageclient "github.com/openshift/origin/pkg/image/generated/internalclientset/typed/image/internalversion" | |||
| "github.com/openshift/origin/pkg/oc/admin/policy" | |||
There was a problem hiding this comment.
Who depends on pkg/build/generator? Anyone outside of oc?
|
This looks pretty good to me. Check for conflicts with the rebase branch. |
Found the following files, outside of
|
|
ok, then that helper duplication is fine.
…On Thu, Nov 16, 2017 at 10:13 AM, Juan Vallejo ***@***.***> wrote:
@deads2k <https://github.com/deads2k>
Who depends on pkg/build/generator? Anyone outside of oc?
Found the following files, outside of pkg/oc, with references to
pkg/build/generator:
- pkg/image/controller/trigger/image_trigger_controller_test.go
- pkg/build/apiserver/apiserver.go
- pkg/build/controller/buildconfig/buildconfig_controller.go
- pkg/build/controller/build/build_controller.go
- pkg/build/registry/buildconfiginstantiate/rest_test.go
- pkg/build/registry/buildconfiginstantiate/rest.go
- pkg/build/registry/buildclone/rest_test.go
- pkg/build/registry/buildclone/rest.go
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17332 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AH2BSulLjeNbbAxYzLsyWGpUI_IESSRpks5s3FEZgaJpZM4QfqCl>
.
|
juanvallejo
force-pushed
the
jvallejo/move-some-files-to-pkg-oc
branch
2 times, most recently
from
fc2145d to
7159b54
Compare
Thanks, this caused no conflict locally with the rebase branch |
Ok. Get green, then re-check. If you're still clear I'll merge. |
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, juanvallejo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
/retest |
|
/test extended_builds |
|
/test extended_conformance_gce |
juanvallejo
force-pushed
the
jvallejo/move-some-files-to-pkg-oc
branch
from
7159b54 to
825526b
Compare
|
flaked on #17394 |
|
needs a squash, then lgtm |
juanvallejo
force-pushed
the
jvallejo/move-some-files-to-pkg-oc
branch
from
825526b to
a55bb43
Compare
|
@deads2k thanks, commit squashed |
juanvallejo
force-pushed
the
jvallejo/move-some-files-to-pkg-oc
branch
from
a55bb43 to
9fd5519
Compare
|
@juanvallejo: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 17417, 17332). |
This patch solves a few of the items (currently checked) from #17309
cc @deads2k @openshift/cli-review @liggitt