Allow assign-macvlan annotation to specify an interface

[danwinship]

If the assign-macvlan interface is a string other than "true", assume that it's the name of a network interface and hang the macvlan off that rather than the default interface. This lets you egress-route out a non-default interface (without forcing OpenShift itself to parse the EGRESS_SOURCE environment variable in the pod definition).

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1513764. Needs to be backported to 3.7 and 3.6 quickly for a customer, so we went with a simple solution here.

@openshift/networking PTAL

[knobunc]

Wow. Thanks for the rapid turn-around!

My only concern is that the interface name may not be consistent across all nodes of the cluster. Is that a safe assumption to make? Or are you expected to limit these only to the nodes with the right name (if so we just need to make that very clear in the docs).

[knobunc]

Code looks good to me.

[knobunc]

/test all

[danwinship]

My only concern is that the interface name may not be consistent across all nodes of the cluster.

The customer suggested this feature themselves, so...

Yes, you'd have to make sure to only schedule the pod on nodes that have an interface with the given name. But you already have to be careful to only schedule the pod on nodes that are on the right subnet for the pod's EGRESS_SOURCE.

(We could change things so that you can specify an IP address for the macvlan as an annotation, and have OpenShift find the right interface for that IP. But that would be a much larger change.)

[danwinship]

/retest

[knobunc]

/retest

[knobunc]

LGTM. We can always use an IP address or subnet later if that proves useful.

[danwinship]

/retest

[knobunc]

/retest

[pravisankar]

Need docs update

[pravisankar]

/lgtm
/approve

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, pravisankar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/network/OWNERS [danwinship,pravisankar]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[danwinship]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 17335, 17334, 17372).

[openshift-ci-robot]

@danwinship: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_conformance_install_update	a734b61	link	/test extended_conformance_install_update
ci/openshift-jenkins/cmd	a734b61	link	/test cmd
ci/openshift-jenkins/extended_conformance_gce	a734b61	link	/test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[danwinship]

/cherrypick release-3.7

[openshift-cherrypick-robot]

@danwinship: New pull request created: #17383

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.