switch to hyperkube and remove renames

[deads2k]

This publishes hyperkube and switches to use it instead of renaming the openshift binary.

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [deads2k]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[deads2k]

wow, that worked better than it had any right to.

[deads2k]

/retest

[mfojtik]

can you add test for hyperkube?

[mfojtik]

LGTM

[stevekuznetsov]

Do we need symlinks here for backwards compatibility?

[deads2k]

Do we need symlinks here for backwards compatibility?

A symlink wouldn't work. You could create a bash script if you really wanted to. @smarterclayton didn't indicate it was a requirement.

[stevekuznetsov]

/cc @sdodson

[sdodson]

We don't have any dependencies on kube commands in the installer. This should be fine.

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[openshift-merge-robot]

Automatic merge from submit-queue.

[openshift-ci-robot]

@deads2k: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_conformance_install_update	57a5bef	link	/test extended_conformance_install_update
ci/openshift-jenkins/extended_conformance_gce	57a5bef	link	/test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[smarterclayton]

You're now building hyperkube twice:

++ Building go targets for linux/amd64: images/pod examples/hello-openshift
++ Building go targets for linux/amd64: vendor/k8s.io/kubernetes/cmd/hyperkube pkg/network/sdn-cni-plugin vendor/github.com/containernetworking/cni/plugins/ipam/host-local vendor/github.com/containernetworking/cni/plugins/main/loopback
++ Building go targets for linux/amd64: cmd/openshift cmd/oc cmd/kubefed cmd/template-service-broker vendor/k8s.io/kubernetes/cmd/hyperkube
++ Building go targets for linux/amd64: test/extended/extended.test

Need to remove it from the IMAGE specific targets now that you made it a normal target.

[deads2k]

Need to remove it from the IMAGE specific targets now that you made it a normal target.

Image targets? What have we built?!

[smarterclayton]

:) Image targets are things we only build for Linux today and which are primarily used in images. The stock cross compile target is for anything we expect to work across all platforms for dev and test and end users. I guess we’ll want hyperkube in cross at some point, but only when we actually do the split. On Nov 22, 2017, at 7:32 AM, David Eads <[email protected]> wrote: Need to remove it from the IMAGE specific targets now that you made it a normal target. Image targets? What have we built?! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17369 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p-uN-4GamI25SubCpXT9xs59x-dMks5s5BRigaJpZM4Qijq8> .