Gate fail-swap-on flag with a version check

[liggitt]

Move "fail-on-swap" logic into "openshift start --write-config"

[liggitt]

/test extended_clusterup

[csrwng]

One nit, otherwise lgtm

[csrwng]

this doesn't look like it's used in the code below

[csrwng]

/assign @bparees

[liggitt]

still working on this... semver comparisons with post v3.8.0-alpha.0 versions don't give the answer we want

[liggitt]

updated, PTAL

[liggitt]

/test extended_clusterup

[liggitt]

made sure all of the following work:

oc cluster up
oc cluster up --version=latest
oc cluster up --version=v3.7.0-rc.0

[bparees]

/lgtm

/hold
for passing cluster up test though.

[mfojtik]

/lgtm

[liggitt]

extended test passes the cluster up point, dies waiting for a build to succeed

[liggitt]

once more, with feeling

all the "fail-swap-on" nonsense is contained to the openshift start [node] --write-config path, which oc cluster up exercises

[bparees]

lgtm, let's see how the cluster up tests do.

[bparees]

testing this in my cluster up fixup PR here:
#17338

[bparees]

[WARNING] !!! gofmt needs to be run on the listed files
./pkg/cmd/server/start/start_node.go
[FATAL] Try running 'gofmt -s -d [path]'

[liggitt]

ugh, fixed

[bparees]

/lgtm

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, liggitt, mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/cmd/OWNERS [bparees,liggitt,mfojtik]
• pkg/oc/bootstrap/docker/openshift/OWNERS [bparees,liggitt,mfojtik]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[bparees]

/hold cancel

[liggitt]

extended cluster up passed the bringup point this affects
unit test was a flake
/test unit

[liggitt]

/retest

[liggitt]

/retest

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[openshift-ci-robot]

@liggitt: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_clusterup	2b69c32	link	/test extended_clusterup
ci/openshift-jenkins/extended_conformance_install_update	2b69c32	link	/test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 17405, 17410).