-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the e2e suite to a broader range of tests #17417
Extend the e2e suite to a broader range of tests #17417
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Do you have +/- on number of tests and runtime for this? |
Fixes #17416 by broadening the test scope. still have slim down the set for known failures. |
b08efb2
to
b6bd03e
Compare
b13db01
to
659f2bf
Compare
/retest |
1 similar comment
/retest |
@bparees can you check the build extended_conformance_gce errors? Seems valid but I don't understand what is broken there ;) |
looks like the build steps are just legitimately running faster than we ever would have expected:
which is what the test failure output is telling you. Reduce the expected stage timings to great than 1ms instead of 1000ms and it should be good. The purpose of the test is just to ensure the timings are not zero. |
Drops all selectivity and includes tests by default
659f2bf
to
72daef5
Compare
/test launch-gce |
72daef5
to
a9bab2d
Compare
Green, merging so we get back to approximate coverage. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/test unit |
/test unit |
@mrunalp what I mentioned |
@smarterclayton Thanks! |
/test all [submit-queue is verifying that this PR is safe to merge] |
/test crio |
/retest |
Automatic merge from submit-queue (batch tested with PRs 17417, 17332). |
@smarterclayton: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Drops all selectivity and includes tests by default