Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the e2e suite to a broader range of tests #17417

Merged

Conversation

smarterclayton
Copy link
Contributor

Drops all selectivity and includes tests by default

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2017
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 22, 2017
@stevekuznetsov
Copy link
Contributor

Do you have +/- on number of tests and runtime for this?

@smarterclayton
Copy link
Contributor Author

Fixes #17416 by broadening the test scope. still have slim down the set for known failures.

@smarterclayton smarterclayton force-pushed the alter_conformance_def branch 2 times, most recently from b08efb2 to b6bd03e Compare November 22, 2017 21:22
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 22, 2017
@smarterclayton smarterclayton force-pushed the alter_conformance_def branch 2 times, most recently from b13db01 to 659f2bf Compare November 23, 2017 00:09
@soltysh
Copy link
Contributor

soltysh commented Nov 23, 2017

/retest

1 similar comment
@mfojtik
Copy link
Contributor

mfojtik commented Nov 24, 2017

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Nov 24, 2017

@bparees can you check the build extended_conformance_gce errors? Seems valid but I don't understand what is broken there ;)

@bparees
Copy link
Contributor

bparees commented Nov 24, 2017

looks like the build steps are just legitimately running faster than we ever would have expected:

I1124 08:48:34.085820       1 tar.go:296] Adding to tar: /tmp/build/inputs/Dockerfile as Dockerfile
Step 1 : FROM centos/ruby-22-centos7
Trying to pull repository docker.io/centos/ruby-22-centos7 ... 
latest: Pulling from docker.io/centos/ruby-22-centos7
Digest: sha256:d885792a9118edd0504bc9194b2a34c3d076c95775f2da715e5d21532d25ce42
 ---> 161690d448ba
Step 2 : ENV "BUILD_LOGLEVEL" "5"
 ---> Running in 6c02f5989db8
 ---> f45a7ff0eece
Removing intermediate container 6c02f5989db8
Step 3 : USER root
 ---> Running in bfee690dcd08
 ---> 6feee10cd0ea
Removing intermediate container bfee690dcd08
Step 4 : ENV "OPENSHIFT_BUILD_NAME" "test-1" "OPENSHIFT_BUILD_NAMESPACE" "extended-test-build-timing-pjmwx-w2fmt"
 ---> Running in 3d04802a5cb9
 ---> 8d317cb61be1
Removing intermediate container 3d04802a5cb9
Step 5 : LABEL "io.openshift.build.namespace" "extended-test-build-timing-pjmwx-w2fmt" "io.openshift.build.name" "test-1"
 ---> Running in a9b2146f9784
 ---> 70d77e10fc2c
Removing intermediate container a9b2146f9784
Successfully built 70d77e10fc2c
I1124 08:48:34.924613       1 cfg.go:39] Locating docker auth for image docker-registry.default.svc:5000/extended-test-build-timing-pjmwx-w2fmt/test:latest and type PUSH_DOCKERCFG_PATH

which is what the test failure output is telling you. Reduce the expected stage timings to great than 1ms instead of 1000ms and it should be good. The purpose of the test is just to ensure the timings are not zero.

Drops all selectivity and includes tests by default
@smarterclayton
Copy link
Contributor Author

/test launch-gce

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2017
@smarterclayton
Copy link
Contributor Author

Green, merging so we get back to approximate coverage.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik
Copy link
Contributor

mfojtik commented Nov 27, 2017

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor Author

/test unit

@smarterclayton
Copy link
Contributor Author

/test unit

@smarterclayton
Copy link
Contributor Author

@mrunalp what I mentioned

@mrunalp
Copy link
Member

mrunalp commented Nov 27, 2017

@smarterclayton Thanks!

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@mrunalp
Copy link
Member

mrunalp commented Nov 27, 2017

/test crio

@smarterclayton
Copy link
Contributor Author

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17417, 17332).

@openshift-merge-robot openshift-merge-robot merged commit 9963c31 into openshift:master Nov 27, 2017
@openshift-ci-robot
Copy link

@smarterclayton: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_builds a9bab2d link /test extended_builds
ci/openshift-jenkins/extended_conformance_install a9bab2d link /test extended_conformance_install
ci/openshift-jenkins/extended_conformance_install_update a9bab2d link /test extended_conformance_install_update
ci/openshift-jenkins/extended_conformance_gce a9bab2d link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_crio a9bab2d link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.