Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiarch import tests #17437

Merged
merged 1 commit into from
Nov 23, 2017
Merged

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Nov 23, 2017

fixes #17436

updated this to use an image under our control to which i've pushed amd64, ppc64le, and s390x image versions in a manifestlist.

I didn't do it under the openshift org to avoid confusion if someone stumbles upon them.

for reference I used this tool:
https://github.com/estesp/manifest-tool

and these images:
s390x/busybox
ppc64le/busybox
busybox

pushed to my own repository and this manifest yaml input to the manifest-tool.

image: bparees/multiplatformtest:latest
manifests:
   -
     image: bparees/multiplatformtest:amd64
     platform:
       architecture: amd64
       os: linux
   -
     image: bparees/multiplatformtest:ppc64le
     platform:
       architecture: ppc64le
       os: linux
   -
     image: bparees/multiplatformtest:s390x
     platform:
       architecture: s390x
       os: linux

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2017
@bparees
Copy link
Contributor Author

bparees commented Nov 23, 2017

/assign @smarterclayton

@bparees bparees changed the title disable multiarch import tests fix multiarch import tests Nov 23, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2017
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2017
@bparees
Copy link
Contributor Author

bparees commented Nov 23, 2017

i'm self lgtm'ing since this is blocking the queue and i don't want Brno blocked tomorrow.

@mfojtik @miminar fyi.

@bparees bparees added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Nov 23, 2017

/test extended_networking_minimal

@mfojtik
Copy link
Contributor

mfojtik commented Nov 23, 2017

Will give extended_networking_minimal one more chance to run and if it fails I'm green button merging this. Thanks @bparees

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 23, 2017

@bparees: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update 2dbe4f4 link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfojtik
Copy link
Contributor

mfojtik commented Nov 23, 2017

all right, this is blocking queue and I don't want to fight with flakes now, so green button merge this is.

@mfojtik mfojtik merged commit 67eb9bc into openshift:master Nov 23, 2017
@bparees
Copy link
Contributor Author

bparees commented Nov 23, 2017 via email

@bparees bparees deleted the docker_manifest branch November 28, 2017 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. queue/critical-fix size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

break: test-cmd broke because of image for ppc64le arch no longer being imported from docker hub
5 participants