move "openshift ex" -> "oc ex" #17486

juanvallejo · 2017-11-27T22:42:26Z

Moves the experimental command group to oc in order to break deps on pkg/oc in packages outside of that subtree. Part of #17309 and #17356

Release-Note: Experimental commands moved from the "openshift" parent to the "oc" parent

cc @deads2k @liggitt

deads2k · 2017-11-28T14:02:06Z

You need a release note on this.

/lgtm

openshift-merge-robot · 2017-11-28T14:02:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, juanvallejo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~pkg/cmd/OWNERS~~ [deads2k]
~~pkg/oc/OWNERS~~ [deads2k]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

juanvallejo · 2017-11-28T22:35:24Z

hack/lib/start.sh

@@ -162,6 +162,7 @@ function os::start::internal::patch_master_config() {
 	local sudo=${USE_SUDO:+sudo}
 	cp "${SERVER_CONFIG_DIR}/master/master-config.yaml" "${SERVER_CONFIG_DIR}/master/master-config.orig.yaml"
 	oc ex config patch "${SERVER_CONFIG_DIR}/master/master-config.orig.yaml" --patch="{\"etcdConfig\": {\"address\": \"${API_HOST}:${ETCD_PORT}\"}}" | \
+	oc ex config patch - --patch="{\"pluginConfig\": {\"openshift.io/ImagePolicy\": {\"configuration\": {\"apiVersion\": \"v1\", \"executionRules\": [{\"matchImageAnnotations\": [{\"key\": \"images.openshift.io/deny-execution\", \"value\": \"true\"}], \"name\": \"execution-denied\", \"onResources\": [{\"resource\": \"pods\"}, {\"resource\": \"builds\"}], \"reject\": \"true\", \"skipOnResolutionFailure\": \"true\" }], \"kind\": \"ImagePolicyConfig\" }, \"location\": \"\"}}}" | \


@deads2k fixes tests in #17473

@deads2k fixes tests in #17473

You can save this commit for that pull. You want to pick up that pull?

@deads2k

You can save this commit for that pull. You want to pick up that pull?

Sure, will start working on the pull now

@deads2k

…g-oc Automatic merge from submit-queue. move pkg/cmd/util/clientcmd -> pkg/oc/cli/util/clientcmd This patch *partially* solves a few of the items (currently checked) from #17309 Now that `clientcmd` (which includes printer factory methods) is moved into `pkg/oc`, the following files outside of `pkg/oc` need to have their dependency on `clientcmd` broken (this will be done in a separate PR): - [x] pkg/cmd/server/origin/controller/config.go (#17357) - [x] pkg/cmd/server/admin/create_error_template.go (#17357) - [x] pkg/cmd/server/admin/create_bootstrap_project_template.go (#17357) - [x] pkg/cmd/server/admin/overwrite_bootstrappolicy.go (*this file has been removed by* #17336) - [x] pkg/cmd/server/admin/create_login_template.go (#17357) - [x] pkg/cmd/server/admin/create_provider_selection_template.go (#17357) - [x] **pkg/cmd/infra/router/template.go** (Wanted by: `pkg/cmd/openshift/openshift.go` (no other dependents)) (#17357) - [x] **pkg/cmd/infra/router/f5.go** (Wanted by: `pkg/cmd/openshift/openshift.go` (no other dependents)) (#17357) - [x] pkg/cmd/openshift/openshift.go (#17486 and #17482) - [x] pkg/cmd/dockerregistry/dockerregistry.go (Wanted by: `cmd/dockerregistry/main.go` (depends on `clientcmd.Config`)) (#17357) - [x] *pkg/diagnostics/networkpod/util/util.go* (Can be addressed by moving `pkg/diagnostics` inside existing `pkg/oc/admin/diagnostics`) #17393 - [x] *pkg/diagnostics/client/config_contexts.go* (Can be addressed by moving `pkg/diagnostics` inside existing `pkg/oc/admin/diagnostics`) #17393 - [x] *pkg/diagnostics/client/run_diagnostics_pod.go* (Can be addressed by moving `pkg/diagnostics` inside existing `pkg/oc/admin/diagnostics`) #17393 - [x] *pkg/diagnostics/pod/auth.go* (Can be addressed by moving `pkg/diagnostics` inside existing `pkg/oc/admin/diagnostics`) #17393 - [x] *pkg/diagnostics/network/run_pod.go* (Can be addressed by moving `pkg/diagnostics` inside existing `pkg/oc/admin/diagnostics`) #17393 - [x] pkg/ipfailover/keepalived/plugin.go (moved to `pkg/oc/experimental`) (#17357) - [x] pkg/federation/kubefed/kubefed.go (#17357) - [x] pkg/dockerregistry/server/client/client.go (#17357) - [x] pkg/dockerregistry/server/auth_test.go (#17357) **bold** = depends on `clientcmd.Config` (not sure what to do about this) AND only dependent is `pkg/cmd/openshift/openshift.go` cc @deads2k @openshift/cli-review @liggitt

deads2k · 2017-11-29T15:34:51Z

/lgtm

juanvallejo · 2017-11-29T19:32:03Z

/retest

juanvallejo · 2017-11-29T20:39:05Z

/test extended_conformance_install

openshift-ci-robot · 2017-11-29T22:51:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, juanvallejo, openshift-merge-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [deads2k]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

openshift-bot · 2017-11-30T06:08:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

deads2k · 2017-11-30T13:36:17Z

/retest

juanvallejo · 2017-11-30T15:30:15Z

/test extended_conformance_install_update

openshift-ci-robot · 2017-11-30T16:05:33Z

@juanvallejo: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_conformance_install_update	`7c3a54e`	link	`/test extended_conformance_install_update`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot · 2017-11-30T16:10:59Z

Automatic merge from submit-queue.

@deads2k

…eads2k Automatic merge from submit-queue. pick pull 17473: stop adding beta admission config to default master configs Picks up #17473 per the discussion with @deads2k in #17486 (comment) cc @deads2k @liggitt @mfojtik

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 27, 2017

openshift-merge-robot assigned tiran and liggitt Nov 27, 2017

This was referenced Nov 27, 2017

move pkg/cmd/util/clientcmd -> pkg/oc/cli/util/clientcmd #17356

Merged

start breaking deps on pkg/oc #17309

Closed

openshift-ci-robot assigned deads2k Nov 28, 2017

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2017

openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2017

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2017

openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2017

juanvallejo force-pushed the jvallejo/move-ex-cmds-to-pkg-oc branch from 8d455de to 28fea0d Compare November 28, 2017 15:58

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 28, 2017

juanvallejo force-pushed the jvallejo/move-ex-cmds-to-pkg-oc branch 4 times, most recently from 8e8cb26 to b3cf70d Compare November 28, 2017 19:54

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2017

juanvallejo force-pushed the jvallejo/move-ex-cmds-to-pkg-oc branch from b3cf70d to 8b71c30 Compare November 28, 2017 21:44

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2017

juanvallejo force-pushed the jvallejo/move-ex-cmds-to-pkg-oc branch from 8b71c30 to 508b618 Compare November 28, 2017 21:46

juanvallejo commented Nov 28, 2017

View reviewed changes

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2017

juanvallejo mentioned this pull request Nov 29, 2017

break dep on clientcmd in pkgs outside pkg oc #17357

Merged

juanvallejo force-pushed the jvallejo/move-ex-cmds-to-pkg-oc branch from c4f50d5 to 508b618 Compare November 29, 2017 18:31

This was referenced Nov 29, 2017

pick pull 17473: stop adding beta admission config to default master configs #17516

Merged

stop adding beta admission config to default master configs #17473

Closed

juanvallejo force-pushed the jvallejo/move-ex-cmds-to-pkg-oc branch from 508b618 to 3310e78 Compare November 29, 2017 19:02

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2017

juanvallejo added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2017

juanvallejo added 3 commits November 29, 2017 17:51

move "openshift ex" -> "oc ex"

4bdb0bd

update tests

28887fa

update completions/docs

7c3a54e

juanvallejo force-pushed the jvallejo/move-ex-cmds-to-pkg-oc branch from 3310e78 to 7c3a54e Compare November 29, 2017 22:51

openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2017

juanvallejo added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2017

openshift-merge-robot merged commit 019702d into openshift:master Nov 30, 2017

juanvallejo deleted the jvallejo/move-ex-cmds-to-pkg-oc branch November 30, 2017 16:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move "openshift ex" -> "oc ex" #17486

move "openshift ex" -> "oc ex" #17486

juanvallejo commented Nov 27, 2017 •

edited

Loading

deads2k commented Nov 28, 2017

openshift-merge-robot commented Nov 28, 2017

juanvallejo Nov 28, 2017

deads2k Nov 29, 2017

juanvallejo Nov 29, 2017

deads2k commented Nov 29, 2017

juanvallejo commented Nov 29, 2017

juanvallejo commented Nov 29, 2017

openshift-ci-robot commented Nov 29, 2017

openshift-bot commented Nov 30, 2017

deads2k commented Nov 30, 2017

juanvallejo commented Nov 30, 2017

openshift-ci-robot commented Nov 30, 2017 •

edited

Loading

openshift-merge-robot commented Nov 30, 2017

move "openshift ex" -> "oc ex" #17486

move "openshift ex" -> "oc ex" #17486

Conversation

juanvallejo commented Nov 27, 2017 • edited Loading

deads2k commented Nov 28, 2017

openshift-merge-robot commented Nov 28, 2017

juanvallejo Nov 28, 2017

Choose a reason for hiding this comment

deads2k Nov 29, 2017

Choose a reason for hiding this comment

juanvallejo Nov 29, 2017

Choose a reason for hiding this comment

deads2k commented Nov 29, 2017

juanvallejo commented Nov 29, 2017

juanvallejo commented Nov 29, 2017

openshift-ci-robot commented Nov 29, 2017

openshift-bot commented Nov 30, 2017

deads2k commented Nov 30, 2017

juanvallejo commented Nov 30, 2017

openshift-ci-robot commented Nov 30, 2017 • edited Loading

openshift-merge-robot commented Nov 30, 2017

juanvallejo commented Nov 27, 2017 •

edited

Loading

openshift-ci-robot commented Nov 30, 2017 •

edited

Loading