Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DC reaper to deal with invalid resource name. #17492

Merged
merged 2 commits into from
Dec 1, 2017
Merged

Fix DC reaper to deal with invalid resource name. #17492

merged 2 commits into from
Dec 1, 2017

Conversation

tnozicka
Copy link
Contributor

It was deleting all RCs because apimachinery .AsSelector() ignores errors and returns MatchAll selector in that case.)

apimachinery issue: kubernetes/apimachinery#31

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1517700

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 28, 2017
@tnozicka
Copy link
Contributor Author

btw. oc delete which just uses kubectl delete doesn't validate resourceName (regexp) - cc @fabianofranz

@tnozicka tnozicka requested a review from mfojtik November 28, 2017 14:36
@tnozicka tnozicka added the kind/bug Categorizes issue or PR as related to a bug. label Nov 28, 2017
@tnozicka
Fix DC reaper to deal with invalid resource name. (It was deleting al…
b75bee4 
…l RCs because apimachinery .AsSelector() ignores errors and returns MatchAll selector in that case.)
@tnozicka
Copy link
Contributor Author

/test unit

@tnozicka
Copy link
Contributor Author

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Nov 28, 2017

hrm, I wonder how can this cause a race, the changes /lgtm

@tnozicka
Copy link
Contributor Author

@mfojtik I think the race was always there, the changes just revealed it

@tnozicka
Copy link
Contributor Author

submit queue stuck...
/test all

@tnozicka
Copy link
Contributor Author

@mfojtik tests are passing, awaiting lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2017
@soltysh
Copy link
Contributor

soltysh commented Nov 30, 2017

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 1, 2017

/retest

@tnozicka tnozicka added this to the 3.8.0 milestone Dec 1, 2017
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 1, 2017 •
edited
Loading

@tnozicka: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update f6f37ad link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 3133750 into openshift:master Dec 1, 2017
@tnozicka tnozicka deleted the fix-dc-reapers branch December 1, 2017 11:44
@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 5, 2017

/cherrypick release-3.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 5, 2017
Merged
@openshift-cherrypick-robot
Copy link

@tnozicka: New pull request created: #17599

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 5, 2017

/cherrypick release-3.6

@openshift-cherrypick-robot
Copy link

@tnozicka: PR 17492 failed to apply on top of branch "release-3.6": exit status 128

In response to this:

/cherrypick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot added a commit that referenced this pull request Jan 6, 2018
@openshift-merge-robot
Merge pull request #17599 from openshift-cherrypick-robot/cherry-pick…
ab12b8b 
…-17492-to-release-3.7

Automatic merge from submit-queue.

Automated cherry-pick of #17492 on release-3.7

This is an automated cherry-pick of #17492

/assign tnozicka
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@mfojtik mfojtik

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v3.8
Development

Successfully merging this pull request may close these issues.
6 participants
@tnozicka @mfojtik @soltysh @openshift-ci-robot @openshift-merge-robot @openshift-cherrypick-robot