hack/lib/init.sh: minor shell and readme improvement #17501
Conversation
openshift-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pgier Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
size/S
openshift-merge-robot
added
the
needs-rebase
Use ${BASH_SOURCE[0]} instead of $0 for consistent behavior when
script is run directly or using 'source hack/lib/init.sh', and
fix regex.
Use tabs instead of spaces for indenting in shell scripts.
The example in the CONTRIBUTING doc adds the locally built
oc binary dir at the end of the PATH. If the user already has oc
in the path then this command won't override it. This just
changes the example to add the local build to the beginning of the PATH
pgier
force-pushed
the
init-script-minor-fix
branch
from
8fc53c8 to
644ad02
Compare
openshift-merge-robot
removed
the
needs-rebase
pgier
changed the title
|
@stevekuznetsov PTAL |
|
Sure, seems reasonable /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pgier, stevekuznetsov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
the
approved
|
/test all |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
@pgier: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue (batch tested with PRs 17451, 17501). |
hack/lib/init.sh: minor shell and readme improvement
Use ${BASH_SOURCE[0]} instead of $0 for consistent behavior when
script is run directly or using 'source hack/lib/init.sh', and
fix regex.
Use tabs instead of spaces for indenting in shell scripts.
The example in the CONTRIBUTING doc adds the locally built
oc binary dir at the end of the PATH. If the user already has oc
in the path then this command won't override it. This just
changes the example to add the local build to the beginning of the PATH