Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent references from origin to oc #17536

Merged
merged 1 commit into from
Dec 5, 2017
Merged

prevent references from origin to oc #17536

merged 1 commit into from
Dec 5, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Nov 30, 2017 •
edited
Loading

Builds on #17516 and #17357

After this, oc can be deleted from origin during the next kube bump.

@juanvallejo missed one. I hacked it in. You'll want to pretty it up eventually.
@eparis @smarterclayton after this merges, I think we're good to branch 3.8.

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 30, 2017
@php-coder
Copy link
Contributor

/unassign

@juanvallejo
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2017
@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Nov 30, 2017
@juanvallejo
Copy link
Contributor

/test extended_clusterup

@deads2k
Copy link
Contributor Author

deads2k commented Nov 30, 2017

/retest

3 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Nov 30, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Nov 30, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Nov 30, 2017

/retest

@juanvallejo
Copy link
Contributor

extended_clusterup flaked on #17548

/test extended_clusterup

@deads2k
Copy link
Contributor Author

deads2k commented Nov 30, 2017

/retest

5 similar comments
@juanvallejo
Copy link
Contributor

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 1, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 1, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 1, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 1, 2017

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, juanvallejo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 1, 2017
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 1, 2017
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Dec 1, 2017

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Dec 1, 2017

/retest

@juanvallejo
Copy link
Contributor

/test crio
/test extended_conformance_gce

@juanvallejo juanvallejo added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2017
@juanvallejo
Copy link
Contributor

/retest

1 similar comment
@juanvallejo
Copy link
Contributor

/retest

@juanvallejo juanvallejo mentioned this pull request Dec 1, 2017
Closed
@juanvallejo
Copy link
Contributor

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Dec 2, 2017

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor Author

deads2k commented Dec 4, 2017

/retest

3 similar comments
@juanvallejo
Copy link
Contributor

/retest

@0xmichalis
Copy link
Contributor

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 5, 2017

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2017 •
edited
Loading

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_clusterup caaa221 link /test extended_clusterup
ci/openshift-jenkins/extended_conformance_crio c1c9636 link /test crio
ci/openshift-jenkins/extended_conformance_install_update c1c9636 link /test extended_conformance_install_update
ci/openshift-jenkins/cmd c1c9636 link /test cmd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17536, 17512).

@openshift-merge-robot openshift-merge-robot merged commit 29bacc4 into openshift:master Dec 5, 2017
@juanvallejo juanvallejo mentioned this pull request Dec 18, 2017
Merged
openshift-merge-robot added a commit that referenced this pull request Jan 6, 2018
@openshift-merge-robot
Merge pull request #17869 from juanvallejo/jvallejo/pick-pr-17536-2nd…
8a52daa 
…-attempt

Automatic merge from submit-queue.

Pick 17536: prevent references from origin to oc

Picks PR #17536 which brings in the last patch needed to eliminate dependencies from origin on the `pkg/oc` subtree.

Re-opened from #17566

cc @deads2k
@deads2k deads2k deleted the oc-01-restrict branch January 24, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanvallejo juanvallejo juanvallejo approved these changes

@enj enj Awaiting requested review from enj

@php-coder php-coder Awaiting requested review from php-coder

Assignees

@juanvallejo juanvallejo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. queue/blocks-others size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deads2k @php-coder @juanvallejo @openshift-ci-robot @openshift-bot @0xmichalis @openshift-merge-robot