Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dind-ovn: use golang binaries instead of python ones #17541

Merged
merged 2 commits into from
Jan 11, 2018

Conversation

rajatchopra
Copy link
Contributor

Dependent on upstream PR: ovn-kubernetes/ovn-kubernetes#173

Signed-off-by: Rajat Chopra [email protected]

@dcbw PTAL. Thanks.

@rajatchopra rajatchopra changed the title Use golang binaries instead of python ones dind-ovn: use golang binaries instead of python ones Nov 30, 2017
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2017
@dcbw
Copy link
Contributor

dcbw commented Dec 1, 2017

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2017
@imcsk8
Copy link
Contributor

imcsk8 commented Dec 1, 2017

LGTM

@dcbw
Copy link
Contributor

dcbw commented Jan 10, 2018

/retest

@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2018
@rajatchopra
Copy link
Contributor Author

@dcbw Added commit to adapt for changes made in ovn-kubernetes/ovn-kubernetes#192
Please review again. Thanks.

@rajatchopra
Copy link
Contributor Author

/test extended_conformance_install

@dcbw
Copy link
Contributor

dcbw commented Jan 11, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, rajatchopra

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 1a5515a into openshift:master Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants