Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split prometheus alerting rules, add new automated recording rules #17553

Merged
merged 3 commits into from
Jan 7, 2018
Merged

Split prometheus alerting rules, add new automated recording rules #17553

merged 3 commits into from
Jan 7, 2018

Conversation

smarterclayton
Copy link
Contributor

The recording rules can be used by federation

Testing this out @karkagis

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2017
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 1, 2017
@csrwng
Copy link
Contributor

csrwng commented Dec 1, 2017

/assign @Kargakis
/unassign

@0xmichalis
Copy link
Contributor

0xmichalis commented Dec 1, 2017 •
edited
Loading

Looks good. I think we will still patch out example-rules because of the node autoscaler.

@aweiteka
Copy link
Contributor

aweiteka commented Dec 1, 2017

+1 to this. thanks.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2017
@smarterclayton
Copy link
Contributor Author

Well, we'll replace the existing node autoscaler soon (when we move to full autoscaling cluster), so that would only be temporary. However, if necessary we can figure out how to stomp it.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2017
@aweiteka aweiteka mentioned this pull request Dec 5, 2017
Closed
@smarterclayton
Split prometheus alerting rules, add new automated recording rules
db29c1c 
The recording rules can be used by federation
@smarterclayton smarterclayton force-pushed the alert_rules branch 2 times, most recently from b6c813d to ba373ca Compare December 11, 2017 21:24
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2017
@smarterclayton
Copy link
Contributor Author

@aweiteka prometheus-standalone.yaml is what is being used for the federation.

@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

@pgier this is a starting point for iteration for a standalone prometheus object. I'm using this for federating a cluster, and config and rules are both split out so they must be provided separately (so not a precanned thing like the ops prometheus).

@smarterclayton
Copy link
Contributor Author

/retest

1 similar comment
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Dec 21, 2017 •
edited
Loading

/retest

@smarterclayton
Copy link
Contributor Author

No other comments?

Merging.

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 6, 2018 •
edited
Loading

@smarterclayton: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_crio dbeadba link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit fe45cf9 into openshift:master Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@0xmichalis 0xmichalis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@smarterclayton @csrwng @0xmichalis @aweiteka @openshift-ci-robot @openshift-bot @openshift-merge-robot