Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude myself from most of the OWNERS files #17557

Merged
merged 2 commits into from
Dec 4, 2017

Conversation

php-coder
Copy link
Contributor

PTAL @simo5 @enj

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 1, 2017
@simo5
Copy link
Contributor

simo5 commented Dec 1, 2017

Ok, let's hold a second on merging this, we may want to make some other changes, let's use this to make all the changes we need at once.

@enj
Copy link
Contributor

enj commented Dec 1, 2017

@php-coder I purposefully added you and the rest of the team to help smear the review burden. But it's up to you on if you want to be in the files.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2017
@php-coder
Copy link
Contributor Author

Added exclusion for @tiran and @legionus as well.

@enj
Copy link
Contributor

enj commented Dec 1, 2017

/approve

@simo5 LGTM if you are happy.

@php-coder
Copy link
Contributor Author

/retest

PTAL @mfojtik

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2017

@php-coder: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install 29d91f0 link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfojtik
Copy link
Contributor

mfojtik commented Dec 4, 2017

@dobbymoodge question: what happens when somebody is removed from the organization? do we have process to remove that users from all OWNERS files? (I guess it is not security problem, because they will be removed from the org, but I guess we need some "pruning" ;-)

/lgtm

(merging with green button as this is not overlapping with anything and it is simple OWNERS change)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, mfojtik, php-coder

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mfojtik mfojtik merged commit b85f660 into openshift:master Dec 4, 2017
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2017
@php-coder php-coder deleted the update_owners branch December 4, 2017 11:41
@0xmichalis
Copy link
Contributor

testing

/cherrypick release-3.7

@0xmichalis
Copy link
Contributor

@mfojtik you can follow kubernetes/test-infra#5175 for what you are asking

@openshift-cherrypick-robot

@Kargakis: #17557 failed to apply on top of branch "release-3.7": exit status 128

In response to this:

testing

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants