-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude myself from most of the OWNERS files #17557
Conversation
Ok, let's hold a second on merging this, we may want to make some other changes, let's use this to make all the changes we need at once. |
@php-coder I purposefully added you and the rest of the team to help smear the review burden. But it's up to you on if you want to be in the files. |
/approve @simo5 LGTM if you are happy. |
/retest PTAL @mfojtik |
@php-coder: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@dobbymoodge question: what happens when somebody is removed from the organization? do we have process to remove that users from all OWNERS files? (I guess it is not security problem, because they will be removed from the org, but I guess we need some "pruning" ;-) /lgtm (merging with green button as this is not overlapping with anything and it is simple OWNERS change) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, mfojtik, php-coder The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
testing /cherrypick release-3.7 |
@mfojtik you can follow kubernetes/test-infra#5175 for what you are asking |
@Kargakis: #17557 failed to apply on top of branch "release-3.7": exit status 128 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PTAL @simo5 @enj