Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the configuration of individual controllers #17572

Merged
merged 2 commits into from
Dec 19, 2017
Merged

Allow the configuration of individual controllers #17572

merged 2 commits into from
Dec 19, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 4, 2017

@mfojtik I was thinking something like this. Untested, but it actually has a good shot at working.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 4, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Dec 4, 2017

tested manually and it works

@smarterclayton using this we should be able to disable malfunctioning controller by updating the master-config.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Dec 4, 2017

@deads2k serialization...

@0xmichalis
Copy link
Contributor

/retest

@0xmichalis
Copy link
Contributor 

./pkg/cmd/server/origin/controller/interfaces.go
./pkg/cmd/server/start/controllers.go
[FATAL] Try running 'gofmt -s -d [path]'
[FATAL] Or autocorrect with 'hack/verify-gofmt.sh | xargs -n 1 gofmt -s -w'

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

soltysh
soltysh approved these changes Dec 5, 2017
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik mfojtik mentioned this pull request Dec 6, 2017
Closed
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k deads2k force-pushed the controller-15-enabledisable branch from 1ff2f71 to 9f2d532 Compare December 7, 2017 13:34
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Dec 7, 2017

@mfojtik @bparees now with fixed migration to respect the old settings. ptal.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2017
@deads2k deads2k force-pushed the controller-15-enabledisable branch from 9f2d532 to 171d733 Compare December 15, 2017 20:49
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2017
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 15, 2017
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Dec 15, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 16, 2017

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor Author

deads2k commented Dec 18, 2017

/retest

1 similar comment
@soltysh
Copy link
Contributor

soltysh commented Dec 19, 2017

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17572, 17746).

@openshift-merge-robot openshift-merge-robot merged commit 78849ac into openshift:master Dec 19, 2017
@deads2k deads2k deleted the controller-15-enabledisable branch January 24, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@csrwng csrwng Awaiting requested review from csrwng

@marun marun Awaiting requested review from marun

Assignees

@mfojtik mfojtik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-api-review size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deads2k @mfojtik @0xmichalis @openshift-bot @openshift-ci-robot @soltysh @openshift-merge-robot