Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove journald limits #17597

Merged

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Dec 5, 2017

@mfojtik this is dropping the hacks we had in place to tweak journald, now that ansible is doing it (openshift/openshift-ansible#3753 and openshift/openshift-ansible#5796). I'm additionally bringing back the deployments e2e's that were suffering from it. Let's see how far we can go with it.

/cc @tnozicka

Fixes #14785

@mfojtik
Copy link
Contributor

mfojtik commented Dec 5, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Dec 5, 2017

/hold

I'll merge this when I prove that journald is not a problem any more

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Dec 5, 2017

/test all

@soltysh
Copy link
Contributor Author

soltysh commented Dec 5, 2017

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2017

@soltysh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update e13aa42 link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Contributor Author

soltysh commented Dec 6, 2017

I think I'm happy with test results, none of them are showing the journald biting us again. I'm letting this in.
/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17217, 17597, 17606).

@openshift-merge-robot openshift-merge-robot merged commit 4c5d83c into openshift:master Dec 6, 2017
@stevekuznetsov
Copy link
Contributor

Hooray?

@soltysh
Copy link
Contributor Author

soltysh commented Dec 7, 2017

Hooray?

I was hoping for a bit more enthusiasm, at least from you Steve 😉

@soltysh soltysh deleted the remove_journald_limits branch December 7, 2017 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants