-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable SchedulerPredicates validates that NodeSelector is respected #17724
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@tnozicka FYI @smarterclayton disabling this test to unblock the queue |
/cherrypick release-3.7 |
@mfojtik: once the present PR merges, I will cherry-pick it on top of release-3.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-3.8 |
@mfojtik: once the present PR merges, I will cherry-pick it on top of release-3.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@mfojtik since this PR is not merged yet and I do not see the same scheduler predicate e2e test is still failing, do we still want to merge this PR? |
This PR is not enough as there are other scheduler predicates tests that are failing for the same reason where router-1-deploy pod not getting scheduled due to either node selector isssue or node being unschedulable. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Unblocks the queue as #17682 is flaking hard. We still have to investigate why the timeout is hit and this should be reverted when we have fix.