Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SDN exponential backoff timeouts #17739

Merged
merged 2 commits into from
Dec 22, 2017
Merged

Fix SDN exponential backoff timeouts #17739

merged 2 commits into from
Dec 22, 2017

Conversation

pravisankar
Copy link

  • First iteration of wait.ExponentialBackoff() will not wait, so
    the times will be:
    0, a, a * r, a * r^2, ... a * r^n-2 [a: duration, r: factor, n: steps]
    Total = a * (r^(n-1) - 1)/(r-1))

  • Moved getLocalSubnet() from node/sdn_controller.go to node/subnets.go

Ravi Sankar Penta added 2 commits December 12, 2017 20:57
Fix SDN exponential backoff timeouts
ac0793c 
- First iteration of wait.ExponentialBackoff() will not wait, so
  the times will be:
  0, a, a * r, a * r^2, ... a * r^n-2 [a: duration, r: factor, n: steps]
  Total = a * (r^(n-1) - 1)/(r-1))
Moved getLocalSubnet() from node/sdn_controller.go to node/subnets.go
2603e1f 
- subnets.go handles subnet related operations and it seems logical to keep
  getLocalSubnet() in this file.
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 13, 2017
@pravisankar pravisankar added component/networking sig/networking and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2017
@pravisankar
Copy link
Author

@openshift/networking PTAL

@pravisankar pravisankar added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2017
@pravisankar
Copy link
Author

/retest

@pravisankar
Copy link
Author

/test cmd

@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2017
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

rajatchopra
rajatchopra approved these changes Dec 18, 2017
View reviewed changes
Copy link
Contributor

@rajatchopra rajatchopra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, pravisankar, rajatchopra

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 24d4f09 into openshift:master Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajatchopra rajatchopra rajatchopra approved these changes

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@danwinship danwinship

@rajatchopra rajatchopra

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/networking lgtm Indicates that a PR is ready to be merged. sig/networking size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pravisankar @danwinship @openshift-bot @openshift-ci-robot @openshift-merge-robot @rajatchopra