Add kube-system as an immortal namespace #17808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/XS
deads2k
reviewed
Dec 21, 2017
| @@ -198,7 +198,7 @@ func newAdmissionChain(pluginNames []string, admissionConfigFilename string, opt | |||
| switch pluginName { | |||
| case lifecycle.PluginName: | |||
| // We need to include our infrastructure and shared resource namespaces in the immortal namespaces list | |||
| immortalNamespaces := sets.NewString(metav1.NamespaceDefault) | |||
| immortalNamespaces := sets.NewString(metav1.NamespaceDefault, metav1.NamespaceSystem) | |||
There was a problem hiding this comment.
This still isn't in sync with upstream. They have NamespacePublic protected too.
There was a problem hiding this comment.
I don't actually care about public… I care about the namespaces which, when deleted, require cluster-admin intervention
There was a problem hiding this comment.
I don't really object to public either
|
opened #17914 as an alternative in head. |
|
closing in favor of #17914 |
openshift-merge-robot
added a commit
that referenced
this pull request
Jan 10, 2018
Automatic merge from submit-queue (batch tested with PRs 17914, 18021, 18022, 17862, 18043). stop special casing creation for ns lifecycle admission alternative to #17808 When running an openshift server, the admission plugin will always want to protect the openshift namespace. This simplifies the admission chain creation path. Only three left.
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this pull request
Jan 24, 2018
Automatic merge from submit-queue (batch tested with PRs 17914, 18021, 18022, 17862, 18043). stop special casing creation for ns lifecycle admission alternative to openshift/origin#17808 When running an openshift server, the admission plugin will always want to protect the openshift namespace. This simplifies the admission chain creation path. Only three left. Origin-commit: f39d2243f75911085ea4b2c379adfae82c0c2011
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this pull request
Jan 25, 2018
Automatic merge from submit-queue (batch tested with PRs 17914, 18021, 18022, 17862, 18043). stop special casing creation for ns lifecycle admission alternative to openshift/origin#17808 When running an openshift server, the admission plugin will always want to protect the openshift namespace. This simplifies the admission chain creation path. Only three left. Origin-commit: f39d2243f75911085ea4b2c379adfae82c0c2011
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this pull request
Feb 27, 2018
Automatic merge from submit-queue (batch tested with PRs 17914, 18021, 18022, 17862, 18043). stop special casing creation for ns lifecycle admission alternative to openshift/origin#17808 When running an openshift server, the admission plugin will always want to protect the openshift namespace. This simplifies the admission chain creation path. Only three left. Origin-commit: f39d2243f75911085ea4b2c379adfae82c0c2011
openshift-publish-robot
pushed a commit
to openshift/kubernetes-apiserver
that referenced
this pull request
Feb 28, 2018
Automatic merge from submit-queue (batch tested with PRs 17914, 18021, 18022, 17862, 18043). stop special casing creation for ns lifecycle admission alternative to openshift/origin#17808 When running an openshift server, the admission plugin will always want to protect the openshift namespace. This simplifies the admission chain creation path. Only three left. Origin-commit: f39d2243f75911085ea4b2c379adfae82c0c2011 Kubernetes-commit: 5d6c9e7ad44fbe3a6ba78153b11501903394ab5b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.