Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack/update-dep.sh proof #17810

Merged
merged 3 commits into from
Dec 20, 2017
Merged

hack/update-dep.sh proof #17810

merged 3 commits into from
Dec 20, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 14, 2017

The kube fork has been pushed, openshift/api and openshift/client-go have been fixed.

This re-bumps, but as part of that, I discovered a sneak crio level that needed to live in pkg/build/builders that was forcing a non-canonical level of containers/storage.

@bparees

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 14, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Dec 14, 2017
@bparees
Copy link
Contributor

bparees commented Dec 14, 2017

[shrug]. lgtm.

@deads2k
Copy link
Contributor Author

deads2k commented Dec 14, 2017

/retest

2 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Dec 14, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 14, 2017

/retest

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Dec 15, 2017

tagging based on ben's comment

@bparees
Copy link
Contributor

bparees commented Dec 15, 2017

can we get a "/shrug" command?

@simo5 simo5 mentioned this pull request Dec 15, 2017
Merged
@simo5
Copy link
Contributor

simo5 commented Dec 15, 2017

/retest

@enj
Copy link
Contributor

enj commented Dec 15, 2017

/shrug

@openshift-ci-robot openshift-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Dec 15, 2017
@simo5
Copy link
Contributor

simo5 commented Dec 15, 2017

/retest

8 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Dec 15, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 15, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 16, 2017

/retest

@simo5
Copy link
Contributor

simo5 commented Dec 17, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 18, 2017

/retest

@simo5
Copy link
Contributor

simo5 commented Dec 18, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 18, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 19, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 19, 2017

/retest

4 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Dec 19, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 19, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 19, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 19, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 20, 2017

#17605

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 20, 2017 •
edited
Loading

@deads2k: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cross d97d178 link /test cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit ecd1110 into openshift:master Dec 20, 2017
@deads2k deads2k deleted the rebase-08-bump branch January 24, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. vendor-update Touching vendor dir or related files ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deads2k @openshift-ci-robot @bparees @simo5 @enj @openshift-merge-robot