Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for broken quota admission test #17830

Merged
merged 1 commit into from
Dec 16, 2017
Merged

Workaround for broken quota admission test #17830

merged 1 commit into from
Dec 16, 2017

Conversation

dmage
Copy link
Contributor

@dmage dmage commented Dec 15, 2017

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2017
@bparees
Copy link
Contributor

bparees commented Dec 15, 2017

@deads2k you mentioned there were some changes to quota in the rebase. Can you please help @dmage understand what they were and what the right way to fix this is so we don't have to wait 10 mins in our tests?

in the meantime, this workaround is ok with me.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, dmage

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2017
@dmage
Copy link
Contributor Author

dmage commented Dec 15, 2017

flake #17697
/retest

@deads2k
Copy link
Contributor

deads2k commented Dec 15, 2017

@dmage @bparees does your problem sound like this: #17803 ? Your fix looks like it is.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16281, 17293, 17717, 17753, 17830).

@openshift-merge-robot openshift-merge-robot merged commit 7edd501 into openshift:master Dec 16, 2017
@dmage
Copy link
Contributor Author

dmage commented Dec 18, 2017

@deads2k I'm not 100% sure how it works, but probably yes. Notifications from the watcher for quota come with a long delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@deads2k deads2k Awaiting requested review from deads2k

@gabemontero gabemontero Awaiting requested review from gabemontero

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dmage @bparees @openshift-ci-robot @deads2k @openshift-merge-robot