Update gitignore for vendored build output files #17848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/XS
|
/retest |
|
lgtm but will defer to @smarterclayton for approval |
stevekuznetsov
force-pushed
the
skuznets/update-gitignore
branch
from
64aa8dc to
49db2e9
Compare
|
@smarterclayton updated |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, stevekuznetsov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/update-gitignore
branch
from
49db2e9 to
70400f6
Compare
openshift-merge-robot
removed
the
lgtm
|
/retest |
|
/test extended_conformance_install |
|
/retest |
|
/retest |
|
FFS GCE /retest |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignoring any directory named
_outputregardless of whether it occursat the project root will ignore build output from vendored projects and
is safe as no real project source will ever live under such a directory.
Signed-off-by: Steve Kuznetsov [email protected]
/cc @smarterclayton @csrwng