Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race in extended deployments test #17889

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Fix race in extended deployments test #17889

merged 1 commit into from
Dec 21, 2017

Conversation

tnozicka
Copy link
Contributor

in "should deal with cancellation after deployer pod succeeded"

Fixes: #17877

/assign @deads2k

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 19, 2017
@tnozicka
Copy link
Contributor Author

/cc @soltysh

soltysh
soltysh approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@tnozicka
Copy link
Contributor Author

/retest

1 similar comment
@soltysh
Copy link
Contributor

soltysh commented Dec 21, 2017

/retest

@tnozicka
Copy link
Contributor Author

flake: #17605
/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

@tnozicka: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 84cdf40 link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install 84cdf40 link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17688, 17889).

@openshift-merge-robot openshift-merge-robot merged commit 283e9ed into openshift:master Dec 21, 2017
@tnozicka tnozicka deleted the fix-race-in-deployment-test branch December 21, 2017 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@soltysh soltysh

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tnozicka @openshift-ci-robot @soltysh @openshift-merge-robot @deads2k