Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin deps 01 3.8 #17896

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Pin deps 01 3.8 #17896

merged 1 commit into from
Jan 11, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 20, 2017

_output/depcheck pin --glide.yaml=glide.yaml --glide.lock=glide.lock and pinning openshift/api and openshift/client-go to a branch

/assign liggitt
/assign juanvallejo

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 20, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Dec 20, 2017
@openshift-merge-robot openshift-merge-robot removed the vendor-update Touching vendor dir or related files label Dec 20, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Dec 20, 2017

/retest

@juanvallejo
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Dec 20, 2017

/hold

@liggitt I don't care about whether this is before or after the rebase.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Dec 20, 2017

/hold

@liggitt I don't care about whether this is before or after the rebase.

Actually, I probably do. we can do this after.

@deads2k deads2k mentioned this pull request Dec 21, 2017
Merged
@deads2k
Copy link
Contributor Author

deads2k commented Jan 3, 2018

/retest

@juanvallejo
Copy link
Contributor

/test end_to_end

@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Jan 10, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2018
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Jan 10, 2018

@liggitt reran this

@deads2k
Copy link
Contributor Author

deads2k commented Jan 10, 2018

/retest

They seem unrelated. @liggitt agree that a glide.yaml update isn't likely to break conformance?

liggitt
liggitt reviewed Jan 10, 2018
View reviewed changes
glide.yaml Outdated
@@ -101,3 +101,388 @@ import:
version: c9de0b92586aaba092c2a231cb7384354b178544
- package: github.com/lestrrat/go-jspointer
version: f4881e611bdbe9fb413a7780721ef8400a1f2341

Copy link
Contributor

@liggitt liggitt Jan 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove the # pinned ones above and regenerate... those were stopgap to get a minimal diff on the rebase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove the # pinned ones above and regenerate... those were stopgap to get a minimal diff on the rebase

done

@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2018
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2018
@liggitt
Copy link
Contributor

liggitt commented Jan 10, 2018

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, juanvallejo, liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 8c9fdbe link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install 8c9fdbe link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor Author

deads2k commented Jan 11, 2018

tested green since the rebase. nothing else has merged. merging this to pin everything

@deads2k deads2k merged commit a28b898 into openshift:release-3.8 Jan 11, 2018
@deads2k deads2k deleted the pin-deps-01-3.8 branch January 24, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

@juanvallejo juanvallejo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deads2k @juanvallejo @liggitt @openshift-ci-robot @openshift-merge-robot