node: skip docker ping check when using fake docker

[csrwng]

When using fake docker

• Skips ping check
• Sets kubelet cgroup driver to default (cgroupfs)

[csrwng]

@deads2k we need to be able to run the kubelet with a fake docker client (which is doable when you set DOCKER_HOST=fake://). However, we implement our own version of Ping() which doesn't use the fake client. This change makes it so we skip the Ping when using the fake Docker client

/cc @stevekuznetsov @smarterclayton

[stevekuznetsov]

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/17979/openshift/origin/integration/10

[stevekuznetsov]

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/17979/openshift/origin/integration/11

[stevekuznetsov]

Just the one failure now:

runner_test.go:124: FAILED TestDiagNodeConditions, retrying:

diag_nodes_test.go:42: expected no warnings with one node ready, but: []types.DiagnosticError{types.DiagnosticError{ID:"DClu0002", LogMessage:"Node 127.0.0.1 is defined but is not marked as ready.\nReady status is False because \"KubeletNotReady\"\nIf the node is not intentionally disabled, check that the master can\nreach the node hostname for a health check and the node is checking in\nto the master with the same hostname.\n\nWhile in this state, pods should not be scheduled to deploy on the node,\nand any existing scheduled pods will be considered failed and removed.\n", Cause:error(nil)}}
etcd.go:140: dumping etcd to "/tmp/openshift/test-integration/tmp-testdiagnodeconditions138363114/etcd-dump-TestDiagNodeConditions-v2.json"

[soltysh]

Why not adding the Ping method to the FakeDockerClient rather than introducing this hack?

[csrwng]

We'd still need to know whether we're using it so we can match the cgroupdriver

[csrwng]

I will open a PR upstream

[soltysh]

Thanks.

[deads2k]

@deads2k we need to be able to run the kubelet with a fake docker client (which is doable when you set DOCKER_HOST=fake://). However, we implement our own version of Ping() which doesn't use the fake client. This change makes it so we skip the Ping when using the fake Docker client

/cc @stevekuznetsov @smarterclayton

I'm ok with it. It's fairly likely to slip during a rebase (type assertions break all the time), so you may want a test.

[stevekuznetsov]

As soon as this is passing our containerized tests it can't slip in a rebase since it will be required to run integration tests in CI

[deads2k]

As soon as this is passing our containerized tests it can't slip in a rebase since it will be required to run integration tests in CI

@csrwng if that's the case, consider yourself on notice for rebase help if this borks badly :)

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/cmd/OWNERS [deads2k]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[csrwng]

This is needed to unblock integration tests. I will create a follow up issue to clean it up

[stevekuznetsov]

/retest

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 17856, 16934, 17979, 17993, 18001).