Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing container to pod logs from dc #18017

Merged
merged 2 commits into from
Jan 9, 2018
Merged

Fix passing container to pod logs from dc #18017

merged 2 commits into from
Jan 9, 2018

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Jan 8, 2018 •
edited
Loading

Fixes: #17999

@Kargakis FYI

~/.../openshift/origin → oc logs dc/docker-registry -c second
openshift v3.9.0-alpha.1+5643835
kubernetes v1.9.0-beta1
etcd 3.2.8
~/.../openshift/origin → oc logs dc/docker-registry
Error from server (BadRequest): a container name must be specified for pod docker-registry-3-f6grl, choose one of: [second registry]

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 8, 2018
@0xmichalis
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2018
@tnozicka
Copy link
Contributor

tnozicka commented Jan 8, 2018

/lgtm as well

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kargakis, mfojtik, tnozicka

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mfojtik
Copy link
Contributor Author

mfojtik commented Jan 8, 2018 •
edited
Loading

/retest

flake: #17883

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 96f2f77 into openshift:master Jan 9, 2018
@mfojtik mfojtik deleted the fix-oc-logs branch September 5, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@0xmichalis 0xmichalis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mfojtik @0xmichalis @tnozicka @openshift-ci-robot @openshift-bot @openshift-merge-robot